From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Mahoney <jeffm@suse.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"
Date: Tue, 05 Apr 2016 11:43:08 +0200 [thread overview]
Message-ID: <1459849388.18188.28.camel@sipsolutions.net> (raw)
In-Reply-To: <5702AF3B.1070507@suse.com> (sfid-20160404_201525_372943_AA6833DD)
On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote:
> This fixes:
>
> net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used
> uninitialized in this function
>
> target_metric is only consumed when reply = true so no bug exists
> here,
> but gcc doesn't notice that. Initializing to 0 clears the warning.
>
What gcc version are you using? Mine doesn't seem to have a problem
following the logic here.
johannes
next prev parent reply other threads:[~2016-04-05 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:15 [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized" Jeff Mahoney
2016-04-05 9:43 ` Johannes Berg [this message]
2016-04-05 13:33 ` Jeff Mahoney
2016-04-05 13:40 ` Johannes Berg
2016-04-05 13:47 ` Jeff Mahoney
2016-04-06 13:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459849388.18188.28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jeffm@suse.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).