From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>,
linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org, kvalo@codeaurora.org,
mohammed@codeaurora.org
Subject: Re: [PATCH v3] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION
Date: Tue, 05 Apr 2016 12:04:10 +0200 [thread overview]
Message-ID: <1459850650.18188.42.camel@sipsolutions.net> (raw)
In-Reply-To: <1457529357-19077-1-git-send-email-mohammed@qca.qualcomm.com>
Hi,
The implementation seems fine now, but I think the commit log needs some work.
> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'
I think it'd be worthwhile to describe the attribute a bit more,
including why you're adding it.
> This flag
There's no flag.
> will be set when drivers can fill rx_duration (aggregate
> PPDU duration(usecs) for all the frames from a peer)
You have the description here, but putting it with the attribute would
be better.
> via 'drv_sta_statistics' callback
drv_sta_statistics is a mac80211 detail, that's not relevant at
cfg80211 level; mentioning that is just confusing. This can well used
by non-mac80211 drivers.
> Also make sta_info flags 'filled' as 64 bit to accommodate for new
> per station stats.
That sentence doesn't parse well.
> Extend 'PUT_SINFO' for supporting rx_duration
> field and any new per sta information in future
That sentence I think should just be removed.
johannes
next prev parent reply other threads:[~2016-04-05 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 13:15 [PATCH v3] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION Mohammed Shafi Shajakhan
2016-03-09 13:15 ` [PATCH v3] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute Mohammed Shafi Shajakhan
2016-04-05 10:04 ` Johannes Berg [this message]
2016-04-05 12:38 ` [PATCH v3] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459850650.18188.42.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@codeaurora.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).