From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Ivanov <dmitrijs.ivanovs@ubnt.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] Do not send netlink socket release notification when socket is not bound
Date: Thu, 07 Apr 2016 09:13:04 +0200 [thread overview]
Message-ID: <1460013184.27154.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20160406172248.b032ff227e4843a836e00802@ubnt.com> (sfid-20160406_162255_804347_6B014CD5)
On Wed, 2016-04-06 at 17:22 +0300, Dmitry Ivanov wrote:
> This patch corrects the problem where non-privileged user may create
> netlink socket with port_id equal to port_id used by hostapd to
> create
> virtual wireless network interfaces. Call to bind() will fail for
> such
> socket, but release notification sent on close() or process
> termination
> to nl80211 subsystem will destroy virtual network interfaces while
> hostapd is still running.
>
Thanks Dmitry.
There are a number of issues with your patch still, such as describing
the problem in too restricted ways (this problem is not specific to
nl80211 nor fixed there). The subject should also have a proper prefix
and you're not sending this patch to the right people.
If you prefer, I can take ownership of these patches.
johannes
prev parent reply other threads:[~2016-04-07 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 14:22 [PATCH 1/2] Do not send netlink socket release notification when socket is not bound Dmitry Ivanov
2016-04-07 7:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460013184.27154.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dmitrijs.ivanovs@ubnt.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).