Re: [PATCH v3 2/3] mac80211_hwsim: Add iface comb for DFS

[Johannes Berg <johannes@sipsolutions.net>]

Hi,

I know this is a LONG time ago, but nonetheless...

> -static struct ieee80211_iface_combination hwsim_if_comb = {
> -	.limits = hwsim_if_limits,
> -	.n_limits = ARRAY_SIZE(hwsim_if_limits),
> -	.max_interfaces = 2048,
> -	.num_different_channels = 1,
> +static const struct ieee80211_iface_limit hwsim_if_dfs_limits[] = {
> +	{ .max = 8, .types = BIT(NL80211_IFTYPE_AP) },
> +};
> +
> +static struct ieee80211_iface_combination hwsim_if_comb[] = {
> +	{
> +		.limits = hwsim_if_limits,
> +		.n_limits = ARRAY_SIZE(hwsim_if_limits),
> +		.max_interfaces = 2048,
> +		.num_different_channels = 1,
> +	},
> +	{
> +		.limits = hwsim_if_dfs_limits,
> +		.n_limits = ARRAY_SIZE(hwsim_if_dfs_limits),
> +		.max_interfaces = 8,
> +		.num_different_channels = 1,
> +		.radar_detect_widths =
> BIT(NL80211_CHAN_WIDTH_20_NOHT) |
> +				       BIT(NL80211_CHAN_WIDTH_20) |
> +				       BIT(NL80211_CHAN_WIDTH_40) |
> +				       BIT(NL80211_CHAN_WIDTH_80) |
> +				       BIT(NL80211_CHAN_WIDTH_160),
> +	}
>  };

I don't, at least today, but I don't see relevant changes since then,
understand why this was two combinations, one with fewer interfaces.

It seems that radar detection is mostly independent of the interface
types, at least as far as the code is concerned.

Are there some other considerations, that prevent declaring
radar_detect_widths together with the regular hwsim_if_limits? It
obviously cannot actually be *used* for all?

johannes