From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: dynamic ps + offchannel mgmt_tx + HW RoC
Date: Tue, 03 May 2016 18:01:02 +0200 [thread overview]
Message-ID: <1462291262.2251.4.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYKj-0kaBP6BYQvcTYZtaTTbtc0nR-=69qC9eCDDJoXxaA@mail.gmail.com> (sfid-20160503_163230_612724_F1B0945E)
On Tue, 2016-05-03 at 20:02 +0530, Krishna Chaitanya wrote:
> > i don't see any issues in the powersave w.r.t driver. Isn't it a
> > valid case? you meant implementing dynamic_ps?
No, I really did mean implementing the entire PS logic in the driver,
instead of having mac80211 do it.
> If it advertise HW_SUPPORTS_DYNAMIC_PS it works fine.
> so may be we should queue those frames and send it to
> HW once it is out of powersave?
We could, but I *really* don't want to patch over the messy and broken
powersave code in mac80211 now.
I really do think that the only way out of this mess is to implement
powersave entirely outside of mac80211; perhaps mac80211 could provide
helpers for it, but tying it into the MLME implementation and having
all the PS-Poll stuff be global etc. is simply wrong today.
johannes
next prev parent reply other threads:[~2016-05-03 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 12:53 dynamic ps + offchannel mgmt_tx + HW RoC Krishna Chaitanya
2016-05-03 13:14 ` Johannes Berg
2016-05-03 14:16 ` Krishna Chaitanya
2016-05-03 14:32 ` Krishna Chaitanya
2016-05-03 16:01 ` Johannes Berg [this message]
2016-05-03 16:58 ` Krishna Chaitanya
2016-05-03 17:21 ` Janusz Dziedzic
2016-05-03 17:42 ` Johannes Berg
2016-05-03 19:35 ` Johannes Berg
2016-05-03 19:50 ` Krishna Chaitanya
2016-05-03 20:03 ` Johannes Berg
2016-05-04 6:38 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462291262.2251.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox