[PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[Aurimas Liutikas]

Signed-off-by: Aurimas Liutikas <aurimas@google.com>

diff --git a/iw.c b/iw.c
index 2aabddb..a6efe5b 100644
--- a/iw.c
+++ b/iw.c
@@ -516,7 +516,7 @@ int main(int argc, char **argv)
        const struct cmd *cmd = NULL;

        /* calculate command size including padding */
-       cmd_size = abs((long)&__section_set - (long)&__section_get);
+       cmd_size = labs((long)&__section_set - (long)&__section_get);
        /* strip off self */
        argc--;
        argv0 = *argv++;

Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[Aurimas Liutikas]

Hey there! Any thoughts on this patch?

Aurimas

On Thu, May 12, 2016 at 9:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:
> Signed-off-by: Aurimas Liutikas <aurimas@google.com>
>
> diff --git a/iw.c b/iw.c
> index 2aabddb..a6efe5b 100644
> --- a/iw.c
> +++ b/iw.c
> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
>         const struct cmd *cmd = NULL;
>
>         /* calculate command size including padding */
> -       cmd_size = abs((long)&__section_set - (long)&__section_get);
> +       cmd_size = labs((long)&__section_set - (long)&__section_get);
>         /* strip off self */
>         argc--;
>         argv0 = *argv++;



-- 

 Aurimas Liutikas | Software Engineer | Chrome / Google

Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[Aurimas Liutikas]

Hello again! I was curious if this looks like a reasonable change?

Aurimas

On Wed, May 18, 2016 at 9:12 AM, Aurimas Liutikas <aurimas@google.com> wrote:
> Hey there! Any thoughts on this patch?
>
> Aurimas
>
> On Thu, May 12, 2016 at 9:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:
>> Signed-off-by: Aurimas Liutikas <aurimas@google.com>
>>
>> diff --git a/iw.c b/iw.c
>> index 2aabddb..a6efe5b 100644
>> --- a/iw.c
>> +++ b/iw.c
>> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
>>         const struct cmd *cmd = NULL;
>>
>>         /* calculate command size including padding */
>> -       cmd_size = abs((long)&__section_set - (long)&__section_get);
>> +       cmd_size = labs((long)&__section_set - (long)&__section_get);
>>         /* strip off self */
>>         argc--;
>>         argv0 = *argv++;
>
>
>
> --
>
>  Aurimas Liutikas | Software Engineer | Chrome / Google



-- 
--
Aurimas Liutikas

Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[Julian Calaby]

Hi Aurimas,

On Fri, May 13, 2016 at 2:16 AM, Aurimas Liutikas <aurimas@google.com> wrote:

You really should add a little more explanation here and include the
exact compiler output you're fixing and mention that this option is
only available with Clang.

> Signed-off-by: Aurimas Liutikas <aurimas@google.com>

Other than that, it looks good to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

One final note, any patch you send to linux-wireless gets entered into
patchwork, so there's no need to keep asking for a review, people are
busy and will get to it eventually.

Thanks,

Julian Calaby

> diff --git a/iw.c b/iw.c
> index 2aabddb..a6efe5b 100644
> --- a/iw.c
> +++ b/iw.c
> @@ -516,7 +516,7 @@ int main(int argc, char **argv)
>         const struct cmd *cmd = NULL;
>
>         /* calculate command size including padding */
> -       cmd_size = abs((long)&__section_set - (long)&__section_get);
> +       cmd_size = labs((long)&__section_set - (long)&__section_get);
>         /* strip off self */
>         argc--;
>         argv0 = *argv++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] iw: Fix -Wabsolute-value compiler warning in iw.c

[Johannes Berg]

Applied.

However, note that I had to do it manually, so if you're planning to
send any more patches please fix your mailer to not corrupt whitespace
(the tabs were replaced by spaces, so the patch couldn't apply
automatically)

johannes