* [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable
@ 2016-06-01 16:23 Colin King
2016-06-03 19:31 ` Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-06-01 16:23 UTC (permalink / raw)
To: Jes Sorensen, Kalle Valo, linux-wireless, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
path_b_ok is being assigned but immediately after path_a_ok is being
compared to the value 0x03. This appears to be a typo on the
variable name, compare path_b_ok instead.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
index fe19ace..b04cf30 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
@@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
for (i = 0; i < retry; i++) {
path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
- if (path_a_ok == 0x03) {
+ if (path_b_ok == 0x03) {
val32 = rtl8xxxu_read32(priv,
REG_RX_POWER_BEFORE_IQK_B_2);
result[t][6] = (val32 >> 16) & 0x3ff;
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable
2016-06-01 16:23 [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable Colin King
@ 2016-06-03 19:31 ` Jes Sorensen
2016-06-07 20:04 ` Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Jes Sorensen @ 2016-06-03 19:31 UTC (permalink / raw)
To: Colin King; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> path_b_ok is being assigned but immediately after path_a_ok is being
> compared to the value 0x03. This appears to be a typo on the
> variable name, compare path_b_ok instead.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> index fe19ace..b04cf30 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>
> for (i = 0; i < retry; i++) {
> path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
> - if (path_a_ok == 0x03) {
> + if (path_b_ok == 0x03) {
> val32 = rtl8xxxu_read32(priv,
> REG_RX_POWER_BEFORE_IQK_B_2);
> result[t][6] = (val32 >> 16) & 0x3ff;
Nice catch, that does indeed look like a bug!
Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
shortly.
Cheers,
Jes
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable
2016-06-03 19:31 ` Jes Sorensen
@ 2016-06-07 20:04 ` Jes Sorensen
0 siblings, 0 replies; 3+ messages in thread
From: Jes Sorensen @ 2016-06-07 20:04 UTC (permalink / raw)
To: Colin King; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel
Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Colin King <colin.king@canonical.com> writes:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> path_b_ok is being assigned but immediately after path_a_ok is being
>> compared to the value 0x03. This appears to be a typo on the
>> variable name, compare path_b_ok instead.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> index fe19ace..b04cf30 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>>
>> for (i = 0; i < retry; i++) {
>> path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
>> - if (path_a_ok == 0x03) {
>> + if (path_b_ok == 0x03) {
>> val32 = rtl8xxxu_read32(priv,
>> REG_RX_POWER_BEFORE_IQK_B_2);
>> result[t][6] = (val32 >> 16) & 0x3ff;
>
> Nice catch, that does indeed look like a bug!
>
> Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
> shortly.
Tested and applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-07 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 16:23 [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable Colin King
2016-06-03 19:31 ` Jes Sorensen
2016-06-07 20:04 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).