From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>, Masashi Honma <masashi.honma@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Encrypt "Group addressed privacy" action frames
Date: Tue, 21 Jun 2016 21:40:49 +0200 [thread overview]
Message-ID: <1466538049.18972.5.camel@sipsolutions.net> (raw)
In-Reply-To: <20160621170120.GA24882@w1.fi> (sfid-20160621_190131_756060_1D067478)
> We actually cover (2) for some cases by "accident" since
> ieee80211_rx_h_decrypt() assigns rx->key to rx->sta->gtk[i] if one is
> available. I'm not completely sure this is correct since it applies
> to management frame as well, but that's the way commit
> 897bed8b4320774e56f282cdc1cceb4d77442797 ('mac80211: clean up RX key
> checks') implemented it (Johannes: Could you please take a look
> whether that gtk[] case was really supposed to apply for non-Data
> frames?).
>
Hm, yeah, that's kinda questionable.
AFAICT we still do the right thing since ieee80211_drop_unencrypted()
contains a check for ieee80211_is_data() and we return in this if
branch, so we never get to the TAINTED check or the actual decrypt.
We could try to just drop unencrypted data frames (that aren't control
port protocol) right here, but it might wreak havoc with the reorder
buffer in case it (erroneously) happens.
johannes
next prev parent reply other threads:[~2016-06-21 20:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 5:38 [PATCH] mac80211: Encrypt "Group addressed privacy" action frames Masashi Honma
2016-06-18 9:11 ` Jouni Malinen
2016-06-20 0:51 ` Masashi Honma
2016-06-20 21:25 ` Jouni Malinen
2016-06-21 6:16 ` Masashi Honma
2016-06-21 17:01 ` Jouni Malinen
2016-06-21 19:40 ` Johannes Berg [this message]
2016-06-22 10:54 ` Masashi Honma
2016-06-22 10:55 ` [PATCH v3] " Masashi Honma
2016-06-29 15:08 ` Masashi Honma
2016-06-29 16:25 ` Johannes Berg
2016-06-29 23:20 ` Masashi Honma
2016-06-21 6:23 ` [PATCH v2] " Masashi Honma
2016-06-21 16:42 ` Jouni Malinen
2016-06-22 10:53 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466538049.18972.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).