From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, jouni@qca.qualcomm.com,
usdutt@qti.qualcomm.com, ganeshk@qti.qualcomm.com,
mkalikot@qca.qualcomm.com, amarnath@qca.qualcomm.com
Subject: Re: [PATCH v2] cfg80211: Allow differnt beacon interval if driver supports
Date: Mon, 18 Jul 2016 21:15:56 +0200 [thread overview]
Message-ID: <1468869356.2944.5.camel@sipsolutions.net> (raw)
In-Reply-To: <9831c426-ae04-a85f-9173-bcea30c489d7@broadcom.com> (sfid-20160718_211359_195109_EC0150EB)
On Mon, 2016-07-18 at 21:13 +0200, Arend Van Spriel wrote:
>
> On 18-7-2016 20:56, Johannes Berg wrote:
> > On Mon, 2016-07-18 at 19:23 +0530, Purushottam Kushwaha wrote:
> > > Driver may allow support for different beacon interval on virtual
> > > interfaces.
> > > Allow if such support is advertised by driver. This adds new
> > > ext_feature as NL80211_EXT_FEATURE_DIFF_BEACON_INTERVAL.
> >
> > We have NL80211_IFACE_COMB_STA_AP_BI_MATCH in interface
> > combinations,
> > perhaps it would make sense to also put this flag there?
>
> Hi Johannes,
>
> Was looking at the same thing. The description of that flag was a bit
> unclear to me.
>
> """
> * @beacon_int_infra_match: In this combination, the beacon intervals
> * between infrastructure and AP types must match. This is
> required
> * only in special cases.
> """
>
> It is not explicitly stated but it implies the STA vif is connected,
> right.
Yes.
Forget this flag. I don't think any driver sets it - it was a hack for
iwldvm. I also don't think any userspace cares about it, and it likely
never really worked. What if the STA vif reconnects anyway?
I was merely pointing this out wrt. the grouping and where to put
something new.
> Probably going off-topic here, but I am also wondering about the
> use-case of the above patch. I have been looking at M-BSS. Toward
> user-space these are AP interfaces, but like described in
> hostapd.conf
> example a number of AP configuration items are required to be equal.
> Now
> we also have chipsets with two 802.11 cores and on each an AP could
> be
> setup with independent beacon interval. So to make the distinction
> would
> it make sense to introduce MBSS_AP iftype? Or does AP_VLAN cover the
> MBSS use-case?
>
I don't think AP_VLAN does, but isn't a mesh portal simply a mesh point
interface and an AP interface?
johannes
next prev parent reply other threads:[~2016-07-18 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 13:53 [PATCH v2] cfg80211: Allow differnt beacon interval if driver supports Purushottam Kushwaha
2016-07-18 16:25 ` Kalle Valo
2016-07-18 18:56 ` Johannes Berg
2016-07-18 19:04 ` Ben Greear
2016-07-18 19:14 ` Johannes Berg
2016-07-18 19:31 ` Ben Greear
2016-07-18 19:13 ` Arend Van Spriel
2016-07-18 19:15 ` Johannes Berg [this message]
2016-07-18 19:21 ` Arend Van Spriel
2016-07-18 19:22 ` Johannes Berg
2016-07-20 13:15 ` Undekari, Sunil Dutt
2016-07-18 19:35 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468869356.2944.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amarnath@qca.qualcomm.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ganeshk@qti.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mkalikot@qca.qualcomm.com \
--cc=pkushwah@qti.qualcomm.com \
--cc=usdutt@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox