linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, jouni@qca.qualcomm.com,
	usdutt@qti.qualcomm.com, ganeshk@qti.qualcomm.com,
	mkalikot@qca.qualcomm.com, amarnath@qca.qualcomm.com
Subject: Re: [PATCH v4] cfg80211: Provision to allow the support for different beacon intervals
Date: Fri, 05 Aug 2016 10:48:32 +0200	[thread overview]
Message-ID: <1470386912.2977.28.camel@sipsolutions.net> (raw)
In-Reply-To: <1470374768-22297-1-git-send-email-pkushwah@qti.qualcomm.com>

On Fri, 2016-08-05 at 10:56 +0530, Purushottam Kushwaha wrote:
> This commit provides the option for the host drivers to advertise the
> support for different beacon intervals among the respective interface
> combinations, through supp_diff_beacon_int (bool).

Neither your commit message nor the documentation makes a direct
reference to this affecting only AP/GO interface. However, you then go
and require that at least 2 interfaces with AP/GO are present.

What if you have AP,GO,mesh in the same interface combination? Either
your documentation needs to very very clearly state that the mesh must
match (either one of them?) and I'd go as far as renaming the APIs, or
you shouldn't require multiple APs and make this apply on mesh and IBSS
as well.

Are there really no restrictions whatsoever, btw?

It seems to me that if I were to specify beacon intervals which have a
very small GCD, you'll run into trouble when actually sending beacons.
Perhaps there should be a requirement on the GCD?

johannes

  reply	other threads:[~2016-08-05  8:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  5:26 [PATCH v4] cfg80211: Provision to allow the support for different beacon intervals Purushottam Kushwaha
2016-08-05  8:48 ` Johannes Berg [this message]
2016-08-08 17:58   ` Undekari, Sunil Dutt
2016-08-09  7:56     ` Johannes Berg
2016-08-10 14:53       ` Undekari, Sunil Dutt
2016-08-10 15:18         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470386912.2977.28.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=amarnath@qca.qualcomm.com \
    --cc=ganeshk@qti.qualcomm.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mkalikot@qca.qualcomm.com \
    --cc=pkushwah@qti.qualcomm.com \
    --cc=usdutt@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).