From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce()
Date: Thu, 11 Aug 2016 14:48:33 +0200 [thread overview]
Message-ID: <1470919713.12075.8.camel@sipsolutions.net> (raw)
In-Reply-To: <1470825209-10054-1-git-send-email-arend.vanspriel@broadcom.com>
On Wed, 2016-08-10 at 12:33 +0200, Arend van Spriel wrote:
> The wrapper rdev_set_coalesce() checks whether the driver provides
> the set_coalesce callback and returns -ENOTSUPP if not. However, this
> check is already performed in nl80211_set_coalesce() resulting in
> -EOPNOTSUPP. This patch removes check from rdev wrapper function.
What's the point though? Presumably the compiler will optimise it out,
and it seems safer to have it this way? Same for all patches in this
series.
johannes
next prev parent reply other threads:[~2016-08-11 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 10:33 [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce() Arend van Spriel
2016-08-10 10:33 ` [PATCH 2/4] cfg80211: rdev-ops: remove callback check from rdev_set_mcast_rate() Arend van Spriel
2016-08-10 10:33 ` [PATCH 3/4] cfg80211: rdev-ops: remove callback check from rdev_start_radar_detection() Arend van Spriel
2016-08-10 10:33 ` [PATCH 4/4] cfg80211: rdev-ops: remove checks from rdev_{add,del}_tx_ts() Arend van Spriel
2016-08-11 12:48 ` Johannes Berg [this message]
2016-08-11 19:00 ` [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce() Arend Van Spriel
2016-08-12 5:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470919713.12075.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).