From: Johannes Berg <johannes@sipsolutions.net>
To: "Kushwaha, Purushottam" <pkushwah@qti.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Malinen, Jouni" <jouni@qca.qualcomm.com>,
"Undekari, Sunil Dutt" <usdutt@qti.qualcomm.com>,
"Kalikot Veetil, Mahesh Kumar" <mkalikot@qca.qualcomm.com>,
"Hullur Subramanyam, Amarnath" <amarnath@qca.qualcomm.com>,
"Kumar, Deepak (QCA)" <djindal@qti.qualcomm.com>
Subject: Re: [PATCH] cfg80211: validate beacon interval for MESH/IBSS
Date: Thu, 11 Aug 2016 14:52:08 +0200 [thread overview]
Message-ID: <1470919928.12075.9.camel@sipsolutions.net> (raw)
In-Reply-To: <99a970ef2b8f4d41b757c4e6b65648ac@aphydexm01b.ap.qualcomm.com>
On Thu, 2016-08-11 at 09:56 +0000, Kushwaha, Purushottam wrote:
> Johannes ,
> While addressing this change, we could notice that the minimum
> boundary for beacon interval for the case of IBSS is 1 but for Mesh
> it is 10. Also this check is not done for AP/P2P GO .
> Any reason why there is a discrepancy among them ? These
> configurations should be aligned , I guess.
> Shouldn't the minimum value be 10 ? If yes , the boundary check
> should be moved to cfg80211_validate_beacon_int ?
>
Yeah, I've applied the patch and moved the range checks in as well.
johannes
prev parent reply other threads:[~2016-08-11 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 9:44 [PATCH] cfg80211: validate beacon interval for MESH/IBSS Purushottam Kushwaha
2016-08-11 9:56 ` Kushwaha, Purushottam
2016-08-11 12:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470919928.12075.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amarnath@qca.qualcomm.com \
--cc=djindal@qti.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mkalikot@qca.qualcomm.com \
--cc=pkushwah@qti.qualcomm.com \
--cc=usdutt@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).