From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce()
Date: Fri, 12 Aug 2016 07:59:29 +0200 [thread overview]
Message-ID: <1470981569.26902.5.camel@sipsolutions.net> (raw)
In-Reply-To: <ee2929c1-1f1b-ca1e-07d2-a3f43f8b73a8@broadcom.com> (sfid-20160811_210047_474331_799A5709)
> I was in doubt to raise the question first about getting this stuff
> consistent, ie. keep rdev-ops as flat as possible, but decided just
> to put it out there in patch format. My bad :-)
:-)
> If you want the rdev-ops to be safe against (future) callers not
> checking the callback, it seems you should add a check in all rdev-
> ops where the callback is optional.
Yeah, perhaps. I don't really mind hugely either way, but I think
removing them now would mostly be unwarranted churn.
johannes
prev parent reply other threads:[~2016-08-12 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 10:33 [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce() Arend van Spriel
2016-08-10 10:33 ` [PATCH 2/4] cfg80211: rdev-ops: remove callback check from rdev_set_mcast_rate() Arend van Spriel
2016-08-10 10:33 ` [PATCH 3/4] cfg80211: rdev-ops: remove callback check from rdev_start_radar_detection() Arend van Spriel
2016-08-10 10:33 ` [PATCH 4/4] cfg80211: rdev-ops: remove checks from rdev_{add,del}_tx_ts() Arend van Spriel
2016-08-11 12:48 ` [PATCH 1/4] cfg80211: rdev-ops: remove callback check from rdev_set_coalesce() Johannes Berg
2016-08-11 19:00 ` Arend Van Spriel
2016-08-12 5:59 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470981569.26902.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).