From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:52314 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbcHONrb (ORCPT ); Mon, 15 Aug 2016 09:47:31 -0400 From: Colin King To: Kalle Valo , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] ath10k: fix memory leak on caldata on error exit path Date: Mon, 15 Aug 2016 14:46:25 +0100 Message-Id: <1471268785-11576-1-git-send-email-colin.king@canonical.com> (sfid-20160815_154751_965993_FF1E71B0) Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Colin Ian King caldata is not being free'd on the error exit path, causing a memory leak. kfree it to fix the leak. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 9a22c47..886337c 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2725,6 +2725,7 @@ static int ath10k_pci_hif_fetch_cal_eeprom(struct ath10k *ar, void **data, return 0; err_free: + kfree(caldata); kfree(data); return -EINVAL; -- 2.8.1