From: Johannes Berg <johannes@sipsolutions.net>
To: Maxim Altshul <maxim.altshul@ti.com>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org
Subject: Re: [PATCH 2/3] wlcore: Pass win_size taken from ieee80211_sta to FW
Date: Thu, 18 Aug 2016 23:23:03 +0200 [thread overview]
Message-ID: <1471555383.28620.5.camel@sipsolutions.net> (raw)
In-Reply-To: <20160818073627.30972-3-maxim.altshul@ti.com>
On Thu, 2016-08-18 at 10:36 +0300, Maxim Altshul wrote:
> When starting a new BA session, we must pass the win_size to the FW.
>
> To do this we take max_rx_aggregation_subframes (BA RX win size)
> which is stored in ieee80211_sta structure (e.g per link and not per
> HW)
I believe this is wrong, and you should use the struct
ieee80211_ampdu_params::buf_size value that's passed to ampdu_action
when the action is IEEE80211_AMPDU_RX_START.
johannes
next prev parent reply other threads:[~2016-08-19 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 7:36 [PATCH 0/3] IOP RX BA session issues Maxim Altshul
2016-08-18 7:36 ` [PATCH 1/3] mac80211: RX BA support for sta max_rx_aggregation_subframes Maxim Altshul
2016-08-18 7:36 ` [PATCH 2/3] wlcore: Pass win_size taken from ieee80211_sta to FW Maxim Altshul
2016-08-18 7:36 ` [PATCH 3/3] wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event Maxim Altshul
2016-08-18 21:23 ` Johannes Berg [this message]
2016-08-18 21:21 ` [PATCH 1/3] mac80211: RX BA support for sta max_rx_aggregation_subframes Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471555383.28620.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maxim.altshul@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).