From: Johannes Berg <johannes@sipsolutions.net>
To: Maxim Altshul <maxim.altshul@ti.com>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org
Subject: Re: [PATCH 1/3 v2] mac80211: RX BA support for sta max_rx_aggregation_subframes
Date: Mon, 22 Aug 2016 15:37:45 +0200 [thread overview]
Message-ID: <1471873065.1363.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20160821112425.11302-1-maxim.altshul@ti.com> (sfid-20160821_131709_224184_1A1775D8)
> + /* examine state machine */
> + mutex_lock(&sta->ampdu_mlme.mtx);
> +
> /* make sure the size doesn't exceed the maximum supported
> by the hw */
> - if (buf_size > local->hw.max_rx_aggregation_subframes)
> - buf_size = local->hw.max_rx_aggregation_subframes;
> + if (buf_size > sta->sta.max_rx_aggregation_subframes)
> + buf_size = sta->sta.max_rx_aggregation_subframes;
> params.buf_size = buf_size;
>
Since the driver is updating this value without any locking, is there
any point in changing the locking?
> + ht_dbg(sta->sdata, "AddBA Req buf_size=%d\n", buf_size);
I think the station address should be in there.
johannes
prev parent reply other threads:[~2016-08-22 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 11:24 [PATCH 1/3 v2] mac80211: RX BA support for sta max_rx_aggregation_subframes Maxim Altshul
2016-08-21 11:24 ` [PATCH 2/3 v2] wlcore: Pass win_size taken from ieee80211_sta to FW Maxim Altshul
2016-08-21 11:24 ` [PATCH 3/3 v2] wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event Maxim Altshul
2016-09-14 16:41 ` [2/3,v2] wlcore: Pass win_size taken from ieee80211_sta to FW Kalle Valo
2016-11-17 6:39 ` Kalle Valo
2016-08-22 13:37 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471873065.1363.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maxim.altshul@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).