From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH 1/3] mwifiex: make "PCI-E is not the winner" print more informative
Date: Thu, 25 Aug 2016 17:05:16 +0200 [thread overview]
Message-ID: <1472137518-10431-2-git-send-email-sgruszka@redhat.com> (raw)
In-Reply-To: <1472137518-10431-1-git-send-email-sgruszka@redhat.com>
Printing ret and adapter->winner do not provide any useful information
as those are always 0 at point where the massage is printed. Print value
read from reg->fw_status register instead.
Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 453ab6a..8abbbfe 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -2074,8 +2074,7 @@ mwifiex_check_winner_status(struct mwifiex_adapter *adapter)
adapter->winner = 1;
} else {
mwifiex_dbg(adapter, ERROR,
- "PCI-E is not the winner <%#x,%d>, exit dnld\n",
- ret, adapter->winner);
+ "PCI-E is not the winner <%#x>", winner);
}
return ret;
--
1.8.3.1
next prev parent reply other threads:[~2016-08-25 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 15:05 [PATCH 0/3] mwifiex: FW downloading debug printing improvements Stanislaw Gruszka
2016-08-25 15:05 ` Stanislaw Gruszka [this message]
2016-09-03 17:03 ` [1/3] mwifiex: make "PCI-E is not the winner" print more informative Kalle Valo
2016-08-25 15:05 ` [PATCH 2/3] mwifiex: print status of FW ready event Stanislaw Gruszka
2016-08-25 15:05 ` [PATCH 3/3] mwifiex: do not print dot when downloading FW Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472137518-10431-2-git-send-email-sgruszka@redhat.com \
--to=sgruszka@redhat.com \
--cc=akarwar@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).