From: Denis Kenzior <denkenz@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH] nl80211: Fix unfiltered GET_INTERFACE dumps
Date: Thu, 25 Aug 2016 15:44:44 -0500 [thread overview]
Message-ID: <1472157884-3174-1-git-send-email-denkenz@gmail.com> (raw)
dump_wiphy_parse only assigns filter_wiphy if one of the supported
NL80211 attributes is present. So for unfiltered dumps, filter_wiphy
was always initialized to 0, and only interface 0 was dumped.
This was introduced in commit 2d75da13fbb957e955d212555b91101cef36f0ce.
Reported-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Denis Kenzior <denkenz@gmail.com>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 95d55d2..ddc994a 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2534,6 +2534,7 @@ static int nl80211_dump_interface(struct sk_buff *skb, struct netlink_callback *
struct nl80211_dump_wiphy_state state = {};
int ret;
+ state.filter_wiphy = -1;
ret = nl80211_dump_wiphy_parse(skb, cb, &state);
if (ret)
return ret;
--
2.7.3
next reply other threads:[~2016-08-25 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 20:44 Denis Kenzior [this message]
2016-08-25 21:35 ` [PATCH] nl80211: Fix unfiltered GET_INTERFACE dumps Arend van Spriel
2016-08-25 21:52 ` Denis Kenzior
2016-08-25 22:07 ` Arend van Spriel
2016-08-26 8:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472157884-3174-1-git-send-email-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).