linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Malinen, Jouni" <jouni@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Xu, Peng" <pxu@qca.qualcomm.com>
Subject: Re: [PATCH] cfg80211: Add HT and VHT information in start_ap
Date: Fri, 26 Aug 2016 10:09:08 +0200	[thread overview]
Message-ID: <1472198948.390.20.camel@sipsolutions.net> (raw)
In-Reply-To: <20160816123441.GA3678@jouni.qca.qualcomm.com>

On Tue, 2016-08-16 at 12:34 +0000, Malinen, Jouni wrote:
> 
> > So if you get HT_VHT_NOT_INDICATED in the driver, don't you *still*
> > have to parse the IEs?
> 
> Well.. Yes, I guess one would need to do that for some time until
> relevant user space is expected to have been updated to support the
> new attribute.

So I guess the question is what drivers would use this, and how, and
would we have to introduce this code into the kernel anyway?

If yes, I'd argue it might as well be in cfg80211 instead of the
driver(s).

> I guess that could be considered reasonable approach for the existing
> HT and VHT cases and new attributes would obviously be significantly
> easier to introduce with new extensions (need to remember to do this
> for HE from the beginning..).

Indeed. I'll try to also remember :)

> The parsing for these HT/VHT enabled/required is a bit strange
> combination having to go over three IEs. I'm not sure a parsing
> function to do so would be that nice.. The parsing code could indeed
> be moved to cfg80211 so that it would not need to be duplicated into
> each driver needing this, though.

Right.

johannes

  reply	other threads:[~2016-08-26  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 18:07 [PATCH] cfg80211: Add HT and VHT information in start_ap Jouni Malinen
2016-08-16  6:52 ` Johannes Berg
2016-08-16 12:34   ` Malinen, Jouni
2016-08-26  8:09     ` Johannes Berg [this message]
2016-09-12 10:09       ` Johannes Berg
2016-10-03 21:15         ` Malinen, Jouni
2016-10-04 13:25           ` Johannes Berg
2016-10-04 16:15             ` Malinen, Jouni
2016-10-13 13:12               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472198948.390.20.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pxu@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).