From: Johannes Berg <johannes@sipsolutions.net>
To: Dave Taht <dave.taht@gmail.com>,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: ath10k <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: [PATCH v3] ath10k: implement NAPI support
Date: Fri, 26 Aug 2016 13:12:00 +0200 [thread overview]
Message-ID: <1472209920.390.34.camel@sipsolutions.net> (raw)
In-Reply-To: <CAA93jw7vHWROH9Ymq1UoOKA5kw+fDbCM=vJehs8J=QP2PVs_RA@mail.gmail.com> (sfid-20160826_124913_305753_49D4FF3C)
On Fri, 2016-08-26 at 03:48 -0700, Dave Taht wrote:
> I'm always rather big on people testing latency under load, and napi
> tends to add some.
That's a completely useless comment.
Obviously, everybody uses NAPI; it's necessary for system load and thus
performance, and lets drivers take advantage of TCP merging to reduce
ACKs, which is tremendously helpful (over wifi in particular.)
Please stop making such drive-by comments that focus only on the single
thing you find important above all; not all people can care only about
that single thing, and unconstructively reiterating it over and over
doesn't help.
Thanks,
johannes
next prev parent reply other threads:[~2016-08-26 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 10:22 [PATCH v3] ath10k: implement NAPI support Rajkumar Manoharan
2016-08-26 10:48 ` Dave Taht
2016-08-26 11:12 ` Johannes Berg [this message]
2016-08-26 11:49 ` Dave Taht
2016-08-26 16:07 ` Rajkumar Manoharan
2016-09-09 12:05 ` [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472209920.390.34.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=dave.taht@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).