* [PATCH] rtlwifi/rtl8192de: Fix print format string
@ 2016-08-27 3:12 Oleg Drokin
2016-08-28 2:30 ` Larry Finger
2016-09-03 17:05 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Oleg Drokin @ 2016-08-27 3:12 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo
Cc: linux-wireless, linux-kernel, Oleg Drokin
%ul was likely meant as %lu to print an unsigned long,
not an unsigned with a letter l at the end.
But in fact the value printed is u32 anyway, so just drop
the l completely.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index d334d2a..2a4810d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -588,7 +588,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
* setting. */
udelay(1);
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
- "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
+ "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
agctab_array_table[i],
agctab_array_table[i + 1]);
}
@@ -604,7 +604,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
* setting. */
udelay(1);
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
- "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
+ "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
agctab_array_table[i],
agctab_array_table[i + 1]);
}
@@ -620,7 +620,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
* setting. */
udelay(1);
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
- "The Rtl819XAGCTAB_5GArray_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
+ "The Rtl819XAGCTAB_5GArray_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
agctab_5garray_table[i],
agctab_5garray_table[i + 1]);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi/rtl8192de: Fix print format string
2016-08-27 3:12 [PATCH] rtlwifi/rtl8192de: Fix print format string Oleg Drokin
@ 2016-08-28 2:30 ` Larry Finger
2016-09-03 17:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2016-08-28 2:30 UTC (permalink / raw)
To: Oleg Drokin, Chaoming Li, Kalle Valo; +Cc: linux-wireless, linux-kernel
On 08/26/2016 10:12 PM, Oleg Drokin wrote:
> %ul was likely meant as %lu to print an unsigned long,
> not an unsigned with a letter l at the end.
> But in fact the value printed is u32 anyway, so just drop
> the l completely.
This patch looks OK, thus
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index d334d2a..2a4810d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -588,7 +588,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
> * setting. */
> udelay(1);
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> + "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
> agctab_array_table[i],
> agctab_array_table[i + 1]);
> }
> @@ -604,7 +604,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
> * setting. */
> udelay(1);
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "The Rtl819XAGCTAB_Array_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> + "The Rtl819XAGCTAB_Array_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
> agctab_array_table[i],
> agctab_array_table[i + 1]);
> }
> @@ -620,7 +620,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,
> * setting. */
> udelay(1);
> RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
> - "The Rtl819XAGCTAB_5GArray_Table[0] is %ul Rtl819XPHY_REGArray[1] is %ul\n",
> + "The Rtl819XAGCTAB_5GArray_Table[0] is %u Rtl819XPHY_REGArray[1] is %u\n",
> agctab_5garray_table[i],
> agctab_5garray_table[i + 1]);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rtlwifi/rtl8192de: Fix print format string
2016-08-27 3:12 [PATCH] rtlwifi/rtl8192de: Fix print format string Oleg Drokin
2016-08-28 2:30 ` Larry Finger
@ 2016-09-03 17:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-09-03 17:05 UTC (permalink / raw)
To: Oleg Drokin
Cc: Larry Finger, Chaoming Li, linux-wireless, linux-kernel,
Oleg Drokin
Oleg Drokin <green@linuxhacker.ru> wrote:
> %ul was likely meant as %lu to print an unsigned long,
> not an unsigned with a letter l at the end.
> But in fact the value printed is u32 anyway, so just drop
> the l completely.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
5856cd5b8dda rtlwifi/rtl8192de: Fix print format string
--
Sent by pwcli
https://patchwork.kernel.org/patch/9302259/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-03 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-27 3:12 [PATCH] rtlwifi/rtl8192de: Fix print format string Oleg Drokin
2016-08-28 2:30 ` Larry Finger
2016-09-03 17:05 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).