linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions
@ 2016-09-02 12:57 Luca Ceresoli
  2016-09-02 16:18 ` Kalle Valo
  2016-09-12  8:14 ` Greg Kroah-Hartman
  0 siblings, 2 replies; 4+ messages in thread
From: Luca Ceresoli @ 2016-09-02 12:57 UTC (permalink / raw)
  To: devel
  Cc: Luca Ceresoli, Larry Finger, Jes Sorensen, Greg Kroah-Hartman,
	linux-wireless, linux-kernel

These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-wireless@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org

---

Changes v1 -> v2:
- improve the commit message.
---
 drivers/staging/rtl8723au/include/recv_osdep.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723au/include/recv_osdep.h b/drivers/staging/rtl8723au/include/recv_osdep.h
index c2d3f1b..c159dbc 100644
--- a/drivers/staging/rtl8723au/include/recv_osdep.h
+++ b/drivers/staging/rtl8723au/include/recv_osdep.h
@@ -26,9 +26,6 @@ int rtw_recv_indicatepkt23a(struct rtw_adapter *adapter, struct recv_frame *prec
 
 void rtw_handle_tkip_mic_err23a(struct rtw_adapter *padapter, u8 bgroup);
 
-int	rtw_init_recv_priv(struct recv_priv *precvpriv, struct rtw_adapter *padapter);
-void rtw_free_recv_priv (struct recv_priv *precvpriv);
-
 int rtw_os_recv_resource_init(struct recv_priv *precvpriv, struct rtw_adapter *padapter);
 
 void rtw_init_recv_timer23a(struct recv_reorder_ctrl *preorder_ctrl);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions
  2016-09-02 12:57 [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions Luca Ceresoli
@ 2016-09-02 16:18 ` Kalle Valo
  2016-09-04 20:52   ` Luca Ceresoli
  2016-09-12  8:14 ` Greg Kroah-Hartman
  1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2016-09-02 16:18 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: devel, Larry Finger, Jes Sorensen, Greg Kroah-Hartman,
	linux-wireless, linux-kernel

Luca Ceresoli <luca@lucaceresoli.net> writes:

> These functions have been declared without any implementation since
> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
> has been no mention of them in following commits.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
>
> ---
>
> Changes v1 -> v2:
> - improve the commit message.
> ---
>  drivers/staging/rtl8723au/include/recv_osdep.h | 3 ---
>  1 file changed, 3 deletions(-)

Please prefix staging drivers with "staging:".

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions
  2016-09-02 16:18 ` Kalle Valo
@ 2016-09-04 20:52   ` Luca Ceresoli
  0 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2016-09-04 20:52 UTC (permalink / raw)
  To: Kalle Valo
  Cc: devel, Larry Finger, Jes Sorensen, Greg Kroah-Hartman,
	linux-wireless, linux-kernel

Dear Kalle,

thanks for your feedback.

On 02/09/2016 18:18, Kalle Valo wrote:
> Luca Ceresoli <luca@lucaceresoli.net> writes:
> 
>> These functions have been declared without any implementation since
>> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
>> has been no mention of them in following commits.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Cc: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: devel@driverdev.osuosl.org
>> Cc: linux-kernel@vger.kernel.org
>>
>> ---
>>
>> Changes v1 -> v2:
>> - improve the commit message.
>> ---
>>  drivers/staging/rtl8723au/include/recv_osdep.h | 3 ---
>>  1 file changed, 3 deletions(-)
> 
> Please prefix staging drivers with "staging:".

Ok, will fix and resubmit.

-- 
Luca

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions
  2016-09-02 12:57 [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions Luca Ceresoli
  2016-09-02 16:18 ` Kalle Valo
@ 2016-09-12  8:14 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-12  8:14 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: devel, Jes Sorensen, linux-wireless, linux-kernel, Larry Finger

On Fri, Sep 02, 2016 at 02:57:44PM +0200, Luca Ceresoli wrote:
> These functions have been declared without any implementation since
> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
> has been no mention of them in following commits.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
> 
> ---
> 
> Changes v1 -> v2:
> - improve the commit message.
> ---
>  drivers/staging/rtl8723au/include/recv_osdep.h | 3 ---
>  1 file changed, 3 deletions(-)

File is no longer in my tree.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-12  8:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-02 12:57 [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions Luca Ceresoli
2016-09-02 16:18 ` Kalle Valo
2016-09-04 20:52   ` Luca Ceresoli
2016-09-12  8:14 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).