From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>, linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Avinash Patil <patila@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 2/2] mwifiex: parse WMM IEs from hostapd for mwifiex AP
Date: Wed, 14 Sep 2016 11:54:31 +0200 [thread overview]
Message-ID: <1473846871.4423.14.camel@sipsolutions.net> (raw)
In-Reply-To: <1357174561-28898-2-git-send-email-bzhao@marvell.com> (sfid-20130103_015637_973661_B4551387)
Obviously this is a very old patch, but I was just looking at users of
cfg80211_find_vendor_ie() and realized you have a bug here:
> + vendor_ie = cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
> + WLAN_OUI_TYPE_MICROSOFT_
> WMM,
> + params->beacon.tail,
> + params-
> >beacon.tail_len);
> + if (vendor_ie) {
> + wmm_ie = (struct ieee_types_header *)vendor_ie;
> + memcpy(&bss_cfg->wmm_info, wmm_ie + 1,
> + sizeof(bss_cfg->wmm_info));
> + priv->wmm_enabled = 1;
You need to check that the vendor_ie is actually long enough.
johannes
next prev parent reply other threads:[~2016-09-14 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 0:56 [PATCH 1/2] mwifiex: use correct htcapinfo for HT20 ibss network Bing Zhao
2013-01-03 0:56 ` [PATCH 2/2] mwifiex: parse WMM IEs from hostapd for mwifiex AP Bing Zhao
2016-09-14 9:54 ` Johannes Berg [this message]
2016-09-20 13:56 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473846871.4423.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox