From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@codeaurora.org>, igor.mitsyanko.os@quantenna.com
Cc: linux-wireless@vger.kernel.org,
Avinash Patil <avinashp@quantenna.com>,
Dmitrii Lebed <dlebed@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Bindu Therthala <btherthala@quantenna.com>,
Huizhao Wang <hwang@quantenna.com>,
Kamlesh Rath <krath@quantenna.com>
Subject: Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets
Date: Sat, 17 Sep 2016 16:50:51 +0200 [thread overview]
Message-ID: <1474123851.7623.2.camel@sipsolutions.net> (raw)
In-Reply-To: <87eg4i8wqi.fsf@kamboji.qca.qualcomm.com>
> drivers/net/wireless/quantenna/qtnfmac/event.c: In function
> `qtnf_event_handle_scan_complete':
> drivers/net/wireless/quantenna/qtnfmac/event.c:342:2: warning:
> passing argument 2 of `cfg80211_scan_done' makes pointer from integer
> without a cast [enabled by default]
Yes, cfg80211_scan_done() changed fairly recently for sure.
> ./include/net/cfg80211.h:4104:6: note: expected `struct
> cfg80211_scan_info *' but argument is of type `u32'
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function
> `qtnf_virtual_intf_cleanup':
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:1093:4: warning:
> passing argument 2 of `cfg80211_scan_done' makes pointer from integer
> without a cast [enabled by default]
> ./include/net/cfg80211.h:4104:6: note: expected `struct
> cfg80211_scan_info *' but argument is of type `int'
>
These also seem related.
> > +F: drivers/net/wireless/quantenna/qtnfmac
> The include directory is not listed.
Should really just stop after quantenna/ I'd think? As long as it's
just a single driver, you might as well claim maintenance over
everything there :)
> I guess some of these static variables could be also const, but
> didn't check.
I think both bitrates and channels can't be, due to cfg80211 writing
some (global) flags there on init.
johannes
next prev parent reply other threads:[~2016-09-17 14:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 22:11 [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets igor.mitsyanko.os
2016-06-21 2:12 ` kbuild test robot
2016-06-21 12:22 ` Johannes Berg
2016-07-11 18:57 ` Igor Mitsyanko
2016-08-01 9:37 ` Johannes Berg
2016-09-17 13:59 ` Kalle Valo
2016-07-19 7:39 ` [v2, " Kalle Valo
2016-09-17 13:46 ` [PATCH v2 " Kalle Valo
2016-09-17 14:50 ` Johannes Berg [this message]
2016-09-17 15:01 ` Kalle Valo
2016-09-17 15:11 ` Johannes Berg
2016-09-17 15:14 ` Kalle Valo
2016-09-20 18:51 ` IgorMitsyanko
2016-09-20 18:51 ` IgorMitsyanko
2016-09-26 10:56 ` Kalle Valo
2016-09-26 12:45 ` IgorMitsyanko
2016-09-26 18:16 ` Kalle Valo
2016-09-17 13:56 ` Kalle Valo
2016-09-20 19:05 ` IgorMitsyanko
2016-09-26 10:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474123851.7623.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avinashp@quantenna.com \
--cc=btherthala@quantenna.com \
--cc=dlebed@quantenna.com \
--cc=hwang@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=krath@quantenna.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=smaksimenko@quantenna.com \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).