From: Luca Coelho <luca@coelho.fi>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
"Beker, Ayala" <ayala.beker@intel.com>,
"Otcheretianski, Andrei" <andrei.otcheretianski@intel.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH v2 2/9] mac80211: add boilerplate code for start / stop NAN
Date: Tue, 20 Sep 2016 17:36:45 +0300 [thread overview]
Message-ID: <1474382205.5664.196.camel@coelho.fi> (raw)
In-Reply-To: <972b9d18-218e-8b46-f56a-eab4c5981d0b@broadcom.com>
Hi Arend,
On Tue, 2016-09-20 at 14:29 +0200, Arend Van Spriel wrote:
> On 20-9-2016 13:45, Beker, Ayala wrote:
> > I don't think there is something in common to those interface types
> > that can fit such a function semantically, so I decided not to
> > change it.
> > Do you have any idea?
>
> What is common is that these are both non-netdev interface types.
I tend to agree with you. I also thought about an
ieee80211_has_netdev() function for this, but I didn't check whether
this was exactly what we need...
In any case, do you mind if we address this in a separate patch?
--
Cheers,
Luca.
next prev parent reply other threads:[~2016-09-20 14:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 8:33 [PATCH v2 0/9] Add support for Neighbor Awareness Networking Luca Coelho
2016-09-16 8:33 ` [PATCH v2 1/9] cfg80211: add start / stop NAN commands Luca Coelho
2016-09-16 10:58 ` Arend Van Spriel
2016-09-16 11:00 ` Johannes Berg
2016-09-18 7:44 ` Otcheretianski, Andrei
2016-09-18 18:54 ` Arend Van Spriel
2016-09-19 7:25 ` Otcheretianski, Andrei
2016-09-16 8:33 ` [PATCH v2 2/9] mac80211: add boilerplate code for start / stop NAN Luca Coelho
2016-09-16 11:08 ` Arend Van Spriel
2016-09-18 7:59 ` Otcheretianski, Andrei
2016-09-18 19:01 ` Arend Van Spriel
2016-09-20 11:45 ` Beker, Ayala
2016-09-20 12:29 ` Arend Van Spriel
2016-09-20 14:36 ` Luca Coelho [this message]
2016-09-21 8:00 ` Arend Van Spriel
2016-09-16 8:33 ` [PATCH v2 3/9] cfg80211: add add_nan_func / rm_nan_func Luca Coelho
2016-09-16 10:46 ` kbuild test robot
2016-09-16 12:20 ` kbuild test robot
2016-09-18 19:28 ` Arend Van Spriel
2016-09-19 7:56 ` Otcheretianski, Andrei
2016-09-18 19:54 ` Arend Van Spriel
2016-09-19 8:09 ` Otcheretianski, Andrei
2016-09-16 8:33 ` [PATCH v2 4/9] cfg80211: allow the user space to change current NAN configuration Luca Coelho
2016-09-18 19:43 ` Arend Van Spriel
2016-09-19 8:07 ` Otcheretianski, Andrei
2016-09-16 8:33 ` [PATCH v2 5/9] cfg80211: provide a function to report a match for NAN Luca Coelho
2016-09-16 8:33 ` [PATCH v2 6/9] cfg80211: Provide an API to report NAN function termination Luca Coelho
2016-09-18 19:56 ` Arend Van Spriel
2016-09-18 20:00 ` Arend Van Spriel
2016-09-19 8:54 ` Otcheretianski, Andrei
2016-09-16 8:33 ` [PATCH v2 7/9] mac80211: implement nan_change_conf Luca Coelho
2016-09-16 8:33 ` [PATCH v2 8/9] mac80211: Implement add_nan_func and rm_nan_func Luca Coelho
2016-09-16 8:33 ` [PATCH v2 9/9] mac80211: Add API to report NAN function match Luca Coelho
2016-09-16 9:00 ` [PATCH v2 0/9] Add support for Neighbor Awareness Networking Arend Van Spriel
2016-09-16 10:26 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474382205.5664.196.camel@coelho.fi \
--to=luca@coelho.fi \
--cc=andrei.otcheretianski@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ayala.beker@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).