From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de
Subject: Re: [RFC] mac80211: fix A-MSDU outer SA/DA
Date: Mon, 10 Oct 2016 12:13:06 +0200 [thread overview]
Message-ID: <1476094386.7895.7.camel@sipsolutions.net> (raw)
In-Reply-To: <1475874542-9014-1-git-send-email-michael-dev@fami-braun.de>
>
> + /* according to IEEE 802.11-2012 8.3.2 table 8-19, the outer
> SA/DA
> + * fields needs to be changed to BSSID for A-MSDU frames
> depending
> + * on FromDS/ToDS values.
> + */
> + hdr = data;
> + if (bssid && (hdr->frame_control &
> cpu_to_le16(IEEE80211_FCTL_FROMDS)))
> + memcpy(amsdu_hdr.h_source, bssid, ETH_ALEN);
> + if (bssid && (hdr->frame_control &
> cpu_to_le16(IEEE80211_FCTL_TODS)))
> + memcpy(amsdu_hdr.h_dest, bssid, ETH_ALEN);
>
You should probably use ieee80211_has_tods() and ieee80211_has_fromds()
johannes
prev parent reply other threads:[~2016-10-10 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 21:09 [RFC] mac80211: fix A-MSDU outer SA/DA Michael Braun
2016-10-10 10:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476094386.7895.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox