From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Stable <stable@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCH] Revert "rtlwifi: rtl818x: constify local structures"
Date: Mon, 10 Oct 2016 18:56:13 +0200 [thread overview]
Message-ID: <1476118573.7895.13.camel@sipsolutions.net> (raw)
In-Reply-To: <20161010152520.9812-1-Larry.Finger@lwfinger.net> (sfid-20161010_172530_909818_2A75F665)
On Mon, 2016-10-10 at 10:25 -0500, Larry Finger wrote:
> This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a.
>
> For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and
> rtl8821ae,
> the Coccinelle script missed the fact that the code changes the
> firmware
> name. When that happens, the kernel issues a BUG splat because
> it is unable to overwrite the old name.
Hmm. That seems somewhat problematic, for example if you have multiple
devices that use the same driver but need different firmware?
Not that I really know what's going on, but changing static variables
based on runtime seems like it could cause issues in such cases.
johannes
next prev parent reply other threads:[~2016-10-10 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 15:25 [PATCH] Revert "rtlwifi: rtl818x: constify local structures" Larry Finger
2016-10-10 16:56 ` Johannes Berg [this message]
2016-10-10 20:28 ` Larry Finger
2016-10-10 20:33 ` Julia Lawall
2016-10-12 8:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476118573.7895.13.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).