From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de
Subject: Re: [PATCH] mac80211: fix A-MSDU outer SA/DA
Date: Wed, 12 Oct 2016 09:57:28 +0200 [thread overview]
Message-ID: <1476259048.5271.15.camel@sipsolutions.net> (raw)
In-Reply-To: <1476258794.5271.12.camel@sipsolutions.net>
On Wed, 2016-10-12 at 09:53 +0200, Johannes Berg wrote:
> On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote:
> >
> > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer
> > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS
> > values.
>
> "Need to" is perhaps a bit strongly worded, but whatever :)
>
> I was going to write a long reply and whatever - but I think that's
> all moot. As far as I can tell, you got this completely wrong, as
> you're changing the *inner* headers, not the *outer* header as you
> should?
Oh, no, my mistake - this happens before 802.3->.11 conversion.
So this does look correct, but I don't like that you write to
amsdu_hdr.h_{source,dest} twice after the patch.
I think you should have da and sa variables and set those, and then
memcpy only once.
johannes
prev parent reply other threads:[~2016-10-12 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 16:52 [PATCH] mac80211: fix A-MSDU outer SA/DA Michael Braun
2016-10-12 7:53 ` Johannes Berg
2016-10-12 7:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476259048.5271.15.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).