From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, vamsi krishna <vamsin@qti.qualcomm.com>
Subject: Re: [PATCH] cfg80211: Add support to update connection parameters
Date: Fri, 14 Oct 2016 09:27:03 +0200 [thread overview]
Message-ID: <1476430023.4382.13.camel@sipsolutions.net> (raw)
In-Reply-To: <61aa0cc9-6485-b206-56ce-cd682d91dd96@broadcom.com> (sfid-20161013_205825_310572_BFC39EA5)
> > /**
> > + * struct cfg80211_connect_params_valid - Connection parame ters
> > to be updated
>
> What's in a name? Could we just use '_updated' instead of '_valid'
> here and below.
In mac80211 we typically just have a single "u32 changed" argument,
with bits defined in an enum - wouldn't that be sufficient here as
well?
johannes
next prev parent reply other threads:[~2016-10-14 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 15:39 [PATCH] cfg80211: Add support to update connection parameters Jouni Malinen
2016-10-13 18:58 ` Arend van Spriel
2016-10-14 7:27 ` Johannes Berg [this message]
2016-10-14 7:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476430023.4382.13.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vamsin@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).