From: Johannes Berg <johannes@sipsolutions.net>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: herbert@gondor.apana.org.au, j@w1.fi, luto@amacapital.net
Subject: Re: [RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU
Date: Tue, 18 Oct 2016 16:16:34 +0200 [thread overview]
Message-ID: <1476800194.6425.35.camel@sipsolutions.net> (raw)
In-Reply-To: <1476799713-16188-3-git-send-email-ard.biesheuvel@linaro.org> (sfid-20161018_160844_561124_0C52FCB9)
On Tue, 2016-10-18 at 15:08 +0100, Ard Biesheuvel wrote:
>
> + aead_req = *this_cpu_ptr(ccmp->reqs);
> + if (!aead_req) {
> + aead_req = kzalloc(reqsize + CCM_AAD_LEN, GFP_ATOMIC);
> + if (!aead_req)
> + return -ENOMEM;
> + *this_cpu_ptr(ccmp->reqs) = aead_req;
> + aead_request_set_tfm(aead_req, ccmp->tfm);
> + }
Hmm. Is it really worth having a per-CPU variable for each possible
key? You could have a large number of those (typically three when
you're a client on an AP, and 1 + 1 for each client when you're the
AP).
Would it be so bad to have to set the TFM every time (if that's even
possible), and just have a single per-CPU cache?
johannes
next prev parent reply other threads:[~2016-10-18 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 14:08 [RFC PATCH 0/2] mac80211: aes_ccm: cache AEAD request allocations per CPU Ard Biesheuvel
2016-10-18 14:08 ` [RFC PATCH 1/2] mac80211: aes_ccm: prepare key struct for storing context data Ard Biesheuvel
2016-10-18 14:08 ` [RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU Ard Biesheuvel
2016-10-18 14:16 ` Johannes Berg [this message]
2016-10-18 14:18 ` Ard Biesheuvel
2016-10-18 14:24 ` Johannes Berg
2016-10-18 14:30 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476800194.6425.35.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox