From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Jani Nikula <jani.nikula@intel.com>,
linux-wireless@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw
Date: Fri, 21 Oct 2016 21:56:22 +0200 [thread overview]
Message-ID: <1477079782.4068.50.camel@sipsolutions.net> (raw)
In-Reply-To: <a6fb17b3-0ec6-e23b-4ae3-f84385cf84ae@broadcom.com> (sfid-20161021_205937_290937_4C8B3DB1)
On Fri, 2016-10-21 at 20:59 +0200, Arend van Spriel wrote:
> Me neither. I actually found it annoying to have all kernel-doc above
> the type definition and indeed easy to miss fields. Now struct
> ieee80211_hw is not alone and we have it all over the place in the
> wireless subsystem. Is this something we want to embrace and maybe
> find janitors/newbies/coccinelle-gurus to address it. Not sure if
> coccinelle could deal with this.
I don't think coccinelle can look into comments, though perhaps it
could be used to *place* them - use kernel-doc script to extract them
first, and then make that output a coccinelle script to place the
comment back at the right spot?
Overall though, not sure that's worth it over just doing it by hand
once? Then again, that could be used to mass-convert more ... :)
johannes
next prev parent reply other threads:[~2016-10-21 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 12:57 [PATCH 1/2] mac80211: fix some sphinx warnings Jani Nikula
2016-10-21 12:57 ` [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw Jani Nikula
2016-10-21 13:01 ` Johannes Berg
2016-10-21 13:18 ` Jani Nikula
2016-10-21 18:59 ` Arend van Spriel
2016-10-21 19:56 ` Johannes Berg [this message]
2016-10-26 6:09 ` Johannes Berg
2016-10-26 8:36 ` Jani Nikula
2016-10-26 8:55 ` Johannes Berg
2016-10-21 13:01 ` [PATCH 1/2] mac80211: fix some sphinx warnings Johannes Berg
2016-10-21 13:14 ` Jani Nikula
2016-10-21 13:17 ` Johannes Berg
2016-10-26 6:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477079782.4068.50.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).