From: Johannes Berg <johannes@sipsolutions.net>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Brian Norris <briannorris@google.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Cathy Luo <cluo@marvell.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Ganapathi Bhat <gbhat@marvell.com>
Subject: Re: cfg80211: race problem between suspend and disconnect event
Date: Fri, 21 Oct 2016 23:24:13 +0200 [thread overview]
Message-ID: <1477085053.4068.65.camel@sipsolutions.net> (raw)
In-Reply-To: <7af766c43f2f426b8db177f8d4e67031@SC-EXCH04.marvell.com>
> Yes. In our case, *802_11_DEAUTHENTICATE command downloaded to
> firmware takes care of flushing the keys.
>
> I can see below code in cfg80211's disconnect handling. It seems to
> be there for long time.
Yeah, I saw it, but it's not clear to me that there's much point in it.
In any case, that's an unrelated question in a way, because there
definitely are things happening here that should be "more synchronous",
regardless of whether or not the key deletion makes sense.
> I think, your cfg80211 change will help. We do ensure that
> cfg80211_disconnected() is called before exiting
> mwifiex_cfg80211_disconnect().
> Sending HostCmd_CMD_802_11_DEAUTHENTICATE command to firmware is a
> blocking call. cfg80211_disconnected() is called while handling that
> command's response.
Ah ok, I missed that - I thought it was asynchronous.
> > So somehow you'd have to synchronize with the firmware as well, to
> > process all those things before suspend, I guess?
> >
[...]
> This would not be needed.
Right. Care to test my patch before I properly submit it?
johannes
next prev parent reply other threads:[~2016-10-21 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 16:47 cfg80211: race problem between suspend and disconnect event Amitkumar Karwar
2016-10-20 18:45 ` Johannes Berg
2016-10-21 15:48 ` Amitkumar Karwar
2016-10-21 21:24 ` Johannes Berg [this message]
2016-10-24 14:54 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477085053.4068.65.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=briannorris@google.com \
--cc=cluo@marvell.com \
--cc=gbhat@marvell.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).