From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Luca Coelho <luca@coelho.fi>,
linux-wireless@vger.kernel.org, ayala.beker@intel.com,
andrei.otcheretianski@intel.com,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH v3 3/9] cfg80211: add add_nan_func / del_nan_func
Date: Sat, 22 Oct 2016 22:24:10 +0200 [thread overview]
Message-ID: <1477167850.4123.0.camel@sipsolutions.net> (raw)
In-Reply-To: <6fb30815-b8c8-aff4-86af-d7f496da91b5@broadcom.com> (sfid-20161022_211735_173825_72A3F61D)
On Sat, 2016-10-22 at 21:17 +0200, Arend van Spriel wrote:
> On 20-09-16 16:31, Luca Coelho wrote:
> >
> > + .flags = GENL_ADMIN_PERM,
> Recently the nl80211_ops flags were changed to GENL_UNS_ADMIN_PERM so
> should the NAN commands use that as well?
The dangers of having such code non-upstream for too long...
It probably doesn't really matter, since most namespace uses are
probably hwsim where this isn't available, but yeah, I guess it should
be allowed to a namespace owner since he already "owns" the device if
it's in the namespace.
johannes
next prev parent reply other threads:[~2016-10-22 20:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 14:31 [PATCH v3 0/9] Add support for Neighbor Awareness Networking Luca Coelho
2016-09-20 14:31 ` [PATCH v3 1/9] cfg80211: add start / stop NAN commands Luca Coelho
2016-09-30 11:25 ` Johannes Berg
2016-09-20 14:31 ` [PATCH v3 2/9] mac80211: add boilerplate code for start / stop NAN Luca Coelho
2016-09-20 14:31 ` [PATCH v3 3/9] cfg80211: add add_nan_func / del_nan_func Luca Coelho
2016-10-22 19:17 ` Arend van Spriel
2016-10-22 20:24 ` Johannes Berg [this message]
2016-09-20 14:31 ` [PATCH v3 4/9] cfg80211: allow the user space to change current NAN configuration Luca Coelho
2016-09-20 14:31 ` [PATCH v3 5/9] cfg80211: provide a function to report a match for NAN Luca Coelho
2016-09-20 14:31 ` [PATCH v3 6/9] cfg80211: Provide an API to report NAN function termination Luca Coelho
2016-09-20 14:31 ` [PATCH v3 7/9] mac80211: implement nan_change_conf Luca Coelho
2016-09-20 14:31 ` [PATCH v3 8/9] mac80211: Implement add_nan_func and rm_nan_func Luca Coelho
2016-09-20 14:31 ` [PATCH v3 9/9] mac80211: Add API to report NAN function match Luca Coelho
2016-09-21 9:40 ` [PATCH v3 0/9] Add support for Neighbor Awareness Networking Arend Van Spriel
2016-09-21 11:36 ` Otcheretianski, Andrei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477167850.4123.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.otcheretianski@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ayala.beker@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).