From: Amitkumar Karwar <akarwar@marvell.com>
To: <linux-wireless@vger.kernel.org>
Cc: Cathy Luo <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
<dmitry.torokhov@gmail.com>, <briannorris@google.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: [PATCH 1/5] mwifiex: remove redundant condition in main process
Date: Mon, 24 Oct 2016 19:51:28 +0530 [thread overview]
Message-ID: <1477318892-22877-1-git-send-email-akarwar@marvell.com> (raw)
This condition while calling mwifiex_check_ps_cond() is redundant.
The function internally already takes care of it.
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/net/wireless/marvell/mwifiex/main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 2478ccd..3b31ea2 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -355,10 +355,8 @@ process_start:
/* Check if we need to confirm Sleep Request
received previously */
- if (adapter->ps_state == PS_STATE_PRE_SLEEP) {
- if (!adapter->cmd_sent && !adapter->curr_cmd)
- mwifiex_check_ps_cond(adapter);
- }
+ if (adapter->ps_state == PS_STATE_PRE_SLEEP)
+ mwifiex_check_ps_cond(adapter);
/* * The ps_state may have been changed during processing of
* Sleep Request event.
--
1.9.1
next reply other threads:[~2016-10-24 14:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 14:21 Amitkumar Karwar [this message]
2016-10-24 14:21 ` [PATCH 2/5] mwifiex: use spinlock for 'mwifiex_processing' in shutdown_drv Amitkumar Karwar
2016-10-24 19:19 ` Brian Norris
2016-10-24 23:57 ` Dmitry Torokhov
2016-10-25 16:11 ` Amitkumar Karwar
2016-10-25 16:35 ` Dmitry Torokhov
2016-10-26 15:23 ` Amitkumar Karwar
2016-10-26 16:36 ` Dmitry Torokhov
2016-10-26 16:59 ` Amitkumar Karwar
2016-10-24 23:47 ` Dmitry Torokhov
2016-10-24 23:55 ` Brian Norris
2016-10-25 16:00 ` Amitkumar Karwar
2016-10-24 14:21 ` [PATCH 3/5] mwifiex: do not free firmware dump memory " Amitkumar Karwar
2016-10-24 19:41 ` Brian Norris
2016-10-25 0:17 ` Dmitry Torokhov
2016-10-25 16:23 ` Amitkumar Karwar
2016-10-24 14:21 ` [PATCH 4/5] mwifiex: firmware dump code rearrangement in pcie.c Amitkumar Karwar
2016-10-24 14:21 ` [PATCH 5/5] mwifiex: wait for firmware dump completion in remove_card Amitkumar Karwar
2016-10-24 20:23 ` Brian Norris
2016-10-25 16:30 ` Amitkumar Karwar
2016-10-25 0:14 ` Dmitry Torokhov
2016-10-25 16:20 ` Amitkumar Karwar
2016-10-27 13:20 ` Kalle Valo
2016-11-02 20:45 ` Brian Norris
2016-11-09 12:35 ` Amitkumar Karwar
2016-11-09 20:37 ` Brian Norris
2016-11-10 10:01 ` Amitkumar Karwar
2016-11-16 13:07 ` Amitkumar Karwar
2016-11-16 18:58 ` Brian Norris
2016-10-24 17:43 ` [PATCH 1/5] mwifiex: remove redundant condition in main process Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477318892-22877-1-git-send-email-akarwar@marvell.com \
--to=akarwar@marvell.com \
--cc=briannorris@google.com \
--cc=cluo@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).