From: Luca Coelho <luca@coelho.fi>
To: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
Cc: linux-wireless@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Kalle Valo <kvalo@codeaurora.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Sara Sharon <sara.sharon@intel.com>,
Liad Kaufman <liad.kaufman@intel.com>,
Eyal Shapira <eyal@wizery.com>,
Alexander Bondar <alexander.bondar@intel.com>
Subject: Re: [PATCH v2 2/3] iwlwifi: mvm: rs: Remove unused 'mcs' variable
Date: Wed, 09 Nov 2016 09:28:43 +0200 [thread overview]
Message-ID: <1478676523.3313.14.camel@coelho.fi> (raw)
In-Reply-To: <20161109055033.GA27470@google.com>
Another nitpick....
On Tue, 2016-11-08 at 21:50 -0800, Kirtika Ruchandani wrote:
> Commit 5fc0f76c4 introduced Rx stats from debugfs, the function
> iwl_mvm_reset_frame_stats from that commit defines and sets mcs but does not use
> it. Compiling iwlwifi with W=1 gives this warning -
>
> iwlwifi/mvm/rs.c: In function ‘iwl_mvm_update_frame_stats’:
> iwlwifi/mvm/rs.c:3074:14: warning: variable ‘mcs’ set but not used [-Wunused-but-set-variable]
>
> Fixes: 5fc0f76c43bd (iwlwifi: mvm: add Rx frames statistics via debugfs)
You forgot the quotes here, but no worries, I'll add them.
--
Luca.
prev parent reply other threads:[~2016-11-09 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 5:50 [PATCH v2 2/3] iwlwifi: mvm: rs: Remove unused 'mcs' variable Kirtika Ruchandani
2016-11-09 7:28 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478676523.3313.14.camel@coelho.fi \
--to=luca@coelho.fi \
--cc=alexander.bondar@intel.com \
--cc=arnd@arndb.de \
--cc=emmanuel.grumbach@intel.com \
--cc=eyal@wizery.com \
--cc=johannes.berg@intel.com \
--cc=kirtika.ruchandani@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=liad.kaufman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).