From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Cc: Erik Stromdahl <erik.stromdahl@gmail.com>
Subject: [RFC v2 03/11] ath10k: htc: Removal of unused struct members
Date: Fri, 18 Nov 2016 20:22:43 +0100 [thread overview]
Message-ID: <1479496971-19174-4-git-send-email-erik.stromdahl@gmail.com> (raw)
In-Reply-To: <1479496971-19174-1-git-send-email-erik.stromdahl@gmail.com>
Removed tx_credits_per_max_message and tx_credit_size
from struct ath10k_htc_ep since they are not used
anywhere in the code.
They are just written, never read.
Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
---
drivers/net/wireless/ath/ath10k/htc.c | 6 ------
drivers/net/wireless/ath/ath10k/htc.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 957e828..79d44de 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -815,12 +815,6 @@ int ath10k_htc_connect_service(struct ath10k_htc *htc,
ep->max_tx_queue_depth = conn_req->max_send_queue_depth;
ep->max_ep_message_len = __le16_to_cpu(resp_msg->max_msg_size);
ep->tx_credits = tx_alloc;
- ep->tx_credit_size = htc->target_credit_size;
- ep->tx_credits_per_max_message = ep->max_ep_message_len /
- htc->target_credit_size;
-
- if (ep->max_ep_message_len % htc->target_credit_size)
- ep->tx_credits_per_max_message++;
/* copy all the callbacks */
ep->ep_ops = conn_req->ep_ops;
diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h
index b0f9cf3..f94b25a 100644
--- a/drivers/net/wireless/ath/ath10k/htc.h
+++ b/drivers/net/wireless/ath/ath10k/htc.h
@@ -336,8 +336,6 @@ struct ath10k_htc_ep {
u8 seq_no; /* for debugging */
int tx_credits;
- int tx_credit_size;
- int tx_credits_per_max_message;
bool tx_credit_flow_enabled;
};
--
1.7.9.5
next prev parent reply other threads:[~2016-11-18 19:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 19:22 [RFC v2 00/11] ath10k sdio support Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 01/11] ath10k: htc: made static function public Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 02/11] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2016-11-18 19:22 ` Erik Stromdahl [this message]
2016-11-18 19:22 ` [RFC v2 04/11] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 05/11] ath10k: htc: refactorization Erik Stromdahl
2016-12-13 13:44 ` Valo, Kalle
2016-12-13 13:52 ` Michal Kazior
2016-12-13 17:26 ` Valo, Kalle
2016-12-13 18:37 ` Erik Stromdahl
2016-12-13 19:21 ` Michal Kazior
2016-12-14 13:49 ` Valo, Kalle
2016-12-14 13:46 ` Valo, Kalle
2016-12-14 21:07 ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 06/11] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl
2016-12-16 10:23 ` Valo, Kalle
2016-11-18 19:22 ` [RFC v2 07/11] ath10k: Added SDIO dbg masks Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 08/11] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 09/11] ath10k: Mailbox address definitions Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 10/11] ath10k: Added more host_interest members Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 11/11] ath10k: Added sdio support Erik Stromdahl
2016-12-13 13:10 ` Valo, Kalle
2016-12-15 16:40 ` Valo, Kalle
2016-12-15 20:52 ` Erik Stromdahl
2016-12-16 11:21 ` Valo, Kalle
2016-12-20 18:14 ` Erik Stromdahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479496971-19174-4-git-send-email-erik.stromdahl@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).