From: Johannes Berg <johannes@sipsolutions.net>
To: "Lazar, Alexei Avshalom" <ailizaro@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: cfg80211: add set/get link loss profile
Date: Mon, 28 Nov 2016 15:52:22 +0100 [thread overview]
Message-ID: <1480344742.8107.63.camel@sipsolutions.net> (raw)
In-Reply-To: <7742335b-f05e-edcd-ad80-fd09fb295eab@codeaurora.org>
> Introduce NL80211_CMD_SET_LINK_LOSS_PROFILE and
> NL80211_CMD_GET_LINK_LOSS_PROFILE as it required by the user space
> to configure the link loss profile.
I'm not convinced.
> The link loss profile represents the priority of maintaining link up
> in different link quality environments.
> Three types of behavior for link loss defined:
> LINK_LOSS_PROFILE_RELAXED: prefer maintaining link up even in poor
> link quality environment.
> LINK_LOSS_PROFILE_DEFAULT: The default behavior for maintaining link
> up vs link quality.
> LINK_LOSS_PROFILE_AGGRESSIVE: prefer losing link up in poor link
> quality environment.
What you're doing here is *extremely* vague. No definitions of what
this means, no description of how it's intended to be implemented, no
note even on whether or not this is for full-MAC chips or not, etc.
At least for mac80211, we can define signals to userspace regarding
"link quality" and make decisions in wpa_s then?
> --- a/drivers/net/wireless/ath/wil6210/cfg80211.c
Those changes obviously don't belong into this patch anyway.
johannes
next prev parent reply other threads:[~2016-11-28 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:33 cfg80211: add set/get link loss profile Lazar, Alexei Avshalom
2016-11-10 13:55 ` Kalle Valo
2016-11-17 13:50 ` Lazar, Alexei Avshalom
2016-11-18 11:05 ` Kalle Valo
2016-12-19 10:58 ` Lazar, Alexei Avshalom
2016-12-19 10:58 ` [PATCH v2] " Lazar, Alexei Avshalom
2016-12-20 17:00 ` Dan Williams
2017-03-06 13:54 ` [PATCH v3] " Lazar, Alexei Avshalom
2017-03-29 9:01 ` Johannes Berg
2016-11-28 14:52 ` Johannes Berg [this message]
2016-12-19 10:58 ` Lazar, Alexei Avshalom
2017-01-02 10:45 ` Johannes Berg
2017-03-06 13:54 ` Lazar, Alexei Avshalom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480344742.8107.63.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ailizaro@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).