From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.
Date: Mon, 05 Dec 2016 15:08:11 +0100 [thread overview]
Message-ID: <1480946891.31788.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1480442872-7358-1-git-send-email-greearb@candelatech.com> (sfid-20161129_190824_045626_457405E8)
On Tue, 2016-11-29 at 10:07 -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> For non-station devices. This gives at least some useful
> summary in some cases (especially when we know AP has only one
> station attached, for instance).
I never saw the point in having ethtool statistics for something you
can get elsewhere, but I'm certainly not making it return a random
station's data disregarding everything else. At least the existing ones
are sums so that all stations are taken into account...
You really should just get per-station stuff through nl80211.
johannes
next prev parent reply other threads:[~2016-12-05 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:07 [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats greearb
2016-12-05 14:08 ` Johannes Berg [this message]
2016-12-05 14:44 ` Ben Greear
2016-12-05 14:53 ` Johannes Berg
2016-12-05 15:01 ` Ben Greear
2016-12-05 17:28 ` Felix Fietkau
2016-12-05 18:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480946891.31788.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).