From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
Andrew Zaborowski <andrew.zaborowski@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT
Date: Tue, 06 Dec 2016 08:16:00 +0100 [thread overview]
Message-ID: <1481008560.6610.3.camel@sipsolutions.net> (raw)
In-Reply-To: <584588A2.9090006@gmail.com> (sfid-20161205_163253_374975_2294902F)
On Mon, 2016-12-05 at 09:32 -0600, Denis Kenzior wrote:
> To what purpose? That's like saying that maybe a socket should be
> kept open in case an application crashes.
That socket would be useless, so no, that's not comparable at all. It's
more like saying the disk should be unmounted once 'mount' exits ;-)
Anyway ... I'm not even super against this patch, but you need to fix
things:
* this is actually wrong for authenticate - I'll let you figure out
why by yourself
* you need to teach people to write useful commit messages
johannes
next prev parent reply other threads:[~2016-12-06 7:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 20:56 [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT Andrew Zaborowski
2016-12-05 13:51 ` Johannes Berg
2016-12-05 14:55 ` Denis Kenzior
2016-12-05 14:58 ` Johannes Berg
2016-12-05 15:05 ` Denis Kenzior
2016-12-05 15:14 ` Johannes Berg
2016-12-05 15:32 ` Denis Kenzior
2016-12-06 7:16 ` Johannes Berg [this message]
2016-12-06 21:42 ` Denis Kenzior
2016-12-07 1:40 ` Andrew Zaborowski
2016-12-07 6:19 ` Johannes Berg
2016-12-07 9:49 ` Andrew Zaborowski
2016-12-07 6:15 ` Johannes Berg
2016-12-07 6:40 ` Denis Kenzior
2016-12-07 6:48 ` Johannes Berg
2016-12-07 7:07 ` Denis Kenzior
2016-12-07 7:38 ` Johannes Berg
2016-12-05 15:40 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481008560.6610.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrew.zaborowski@intel.com \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).