linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Zaborowski <andrew.zaborowski@intel.com>,
	Denis Kenzior <denkenz@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT
Date: Wed, 07 Dec 2016 07:19:14 +0100	[thread overview]
Message-ID: <1481091554.4092.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CAOq732LOk-GQiSfs9Js-qEgvmbNMD_xf6j_1NR88Z1SDL=J8WA@mail.gmail.com> (sfid-20161207_024034_624798_FE1BD05B)


> Possibly Johanness refers to the fact that if you use
> CMD_AUTHENTICATE, or if you use CMD_CONNECT but the driver implements
> the SME -- doesn't use the cfg80211 software SME -- then
> cfg80211_disconnect won't do anything if we're not associated, only
> authenticated.  Currently cfg80211 doesn't have knowledge of whether
> it is authenticated and where to.

We used to track it, but it was a nightmare and just always buggy :)

> With the software SME current_bss would be set from the moment the
> authentication attempt starts, 

I'm almost certain this isn't true, what makes you think so?

> so there seems to be an inconsistency
> which would affect for example the NL80211_BSS_STATUS_ASSOCIATED
> flags in the result of CMD_GET_SCAN.

Thus this can't be the case.

> Perhaps this can be fixed by always
> setting current_bss on auth attempt start, with flags to indicate
> whether authentication has happened and whether association happened.

No! That would be wrong!

> At the very least with this patch if you set the socket owner during
> CMD_AUTHENTICATE and then separately associate, you'd get the
> expected deauthentication.

That would *NOT* be expected. There's no need to even authenticate
through CMD_AUTHENTICATE at all to connect to (another) AP!

You need to think beyond the 1996 version of 802.11 ;-)

johannes

  reply	other threads:[~2016-12-07  6:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 20:56 [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT Andrew Zaborowski
2016-12-05 13:51 ` Johannes Berg
2016-12-05 14:55   ` Denis Kenzior
2016-12-05 14:58     ` Johannes Berg
2016-12-05 15:05       ` Denis Kenzior
2016-12-05 15:14         ` Johannes Berg
2016-12-05 15:32           ` Denis Kenzior
2016-12-06  7:16             ` Johannes Berg
2016-12-06 21:42               ` Denis Kenzior
2016-12-07  1:40                 ` Andrew Zaborowski
2016-12-07  6:19                   ` Johannes Berg [this message]
2016-12-07  9:49                     ` Andrew Zaborowski
2016-12-07  6:15                 ` Johannes Berg
2016-12-07  6:40                   ` Denis Kenzior
2016-12-07  6:48                     ` Johannes Berg
2016-12-07  7:07                       ` Denis Kenzior
2016-12-07  7:38                         ` Johannes Berg
2016-12-05 15:40           ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481091554.4092.7.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=andrew.zaborowski@intel.com \
    --cc=denkenz@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).