From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Zaborowski <balrogg@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3][RFC] nl80211/mac80211: Accept multiple RSSI thresholds for CQM
Date: Tue, 13 Dec 2016 17:11:59 +0100 [thread overview]
Message-ID: <1481645519.20412.37.camel@sipsolutions.net> (raw)
In-Reply-To: <CAOq732K88CygXBmDfGmU21AcQHurcWx081Q3SM-b0ecm+848gA@mail.gmail.com> (sfid-20161128_190608_203783_0078941B)
> I wasn't clear: nl80211 sets the thresholds so that "high" is higher
> than last known value and "low" is lower than last known value, also
> the distance is at least 2 x hysteresis. There's no purpose for
> reporting "middle" rssi events because we have to set a new range as
> soon as we receive a high or a low event. I realize I need to
> document better.
But there can be a delay between reporting and reprogramming, and if
during that time a new event could be reported? I guess it doesn't
matter much if we assume that upon reprogramming the driver will always
report a new event if the current value falls outside the new range
(either high or low)... it just seemed a little bit more consistent to
unconditionally report a new event at the beginning, even if that new
event is "yup - falling into the middle of your range now".
johannes
next prev parent reply other threads:[~2016-12-13 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 2:08 [PATCH 0/3][RFC] CQM RSSI event with many thresholds Andrew Zaborowski
2016-11-06 2:08 ` [PATCH 1/3][RFC] mac80211: Pass new RSSI level in CQM RSSI notification Andrew Zaborowski
2016-11-06 2:08 ` [PATCH 2/3][RFC] cfg80211: " Andrew Zaborowski
2016-11-06 2:08 ` [PATCH 3/3][RFC] nl80211/mac80211: Accept multiple RSSI thresholds for CQM Andrew Zaborowski
2016-11-28 14:47 ` Johannes Berg
2016-11-28 15:29 ` Andrew Zaborowski
2016-11-28 15:35 ` Johannes Berg
2016-11-28 18:06 ` Andrew Zaborowski
2016-12-13 16:11 ` Johannes Berg [this message]
2016-12-18 0:18 ` Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481645519.20412.37.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=balrogg@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).