* "rfkill: Add rfkill-any LED trigger" causes deadlock [not found] <20161216163707.GA2629@gmail.com> @ 2016-12-16 16:46 ` Михаил Кринкин 2016-12-16 17:09 ` Mike Krinkin 2016-12-19 8:56 ` Johannes Berg 0 siblings, 2 replies; 5+ messages in thread From: Михаил Кринкин @ 2016-12-16 16:46 UTC (permalink / raw) To: kernel, johannes.berg, linux-wireless, davem, netdev Hi, with recent i can't load my thinkpad with recent linux-next, bisect points at the commit 73f4f76a196d7adb ("rfkill: Add rfkill-any LED trigger"). Problem occurs because thinkapd_acpi rfkill set_block handler tpacpi_rfk_hook_set_block calls rfkill_set_sw_state, which in turn calls new rfkill_any_led_trigger_event. So when rfkill_set_block called from rfkill_register we have deadlock. I added WARN to __rfkill_any_led_trigger_event to see how deadlock occurs, here is backtrace: [ 6.090079] WARNING: CPU: 2 PID: 307 at net/rfkill/core.c:184 rfkill_any_led_trigger_event+0x2d/0x40 [ 6.090080] reached __rfkill_any_led_trigger_event [ 6.090081] Modules linked in: [ 6.090082] snd_pcm sg thinkpad_acpi(+) mei_me nvram snd_seq mei idma64 virt_dma intel_pch_thermal ucsi intel_lpss_pci snd_seq_device hci_uart snd_timer snd btbcm soundcore btqca led_class btintel bluetooth i8042 rtc_cmos serio evdev intel_lpss_acpi intel_lpss acpi_pad tpm_infineon mfd_core kvm_intel kvm irqbypass ipv6 autofs4 ext4 jbd2 mbcache sd_mod i915 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm ahci libahci video pinctrl_sunrisepoint pinctrl_intel [ 6.090112] CPU: 2 PID: 307 Comm: systemd-udevd Tainted: G W 4.9.0-01741-g73f4f76-dirty #106 [ 6.090113] Hardware name: LENOVO 20GJ004ERT/20GJ004ERT, BIOS R0CET21W (1.09 ) 03/07/2016 [ 6.090114] ffffb199c023f998 ffffffffb4334b6b ffffb199c023f9e8 0000000000000000 [ 6.090117] ffffb199c023f9d8 ffffffffb40658ab 000000b84dd75d28 0000000080000006 [ 6.090119] ffff99ea4dd75d28 0000000000000001 0000000000000001 0000000000000000 [ 6.090122] Call Trace: [ 6.090126] [<ffffffffb4334b6b>] dump_stack+0x4d/0x72 [ 6.090128] [<ffffffffb40658ab>] __warn+0xcb/0xf0 [ 6.090130] [<ffffffffb406592f>] warn_slowpath_fmt+0x5f/0x80 [ 6.090132] [<ffffffffb4631bfd>] rfkill_any_led_trigger_event+0x2d/0x40 [ 6.090135] [<ffffffffb46322d9>] rfkill_set_sw_state+0x89/0xd0 [ 6.090142] [<ffffffffc06c9921>] tpacpi_rfk_update_swstate+0x31/0x50 [thinkpad_acpi] [ 6.090148] [<ffffffffc06c9972>] tpacpi_rfk_hook_set_block+0x32/0x70 [thinkpad_acpi] [ 6.090150] [<ffffffffb46327f0>] rfkill_set_block+0x90/0x160 [ 6.090152] [<ffffffffb4632930>] __rfkill_switch_all+0x70/0xa0 [ 6.090154] [<ffffffffb4633028>] rfkill_register+0x278/0x2b0 [ 6.090159] [<ffffffffc06e1f0e>] tpacpi_new_rfkill+0xef/0x15d [thinkpad_acpi] [ 6.090164] [<ffffffffc06e2407>] bluetooth_init+0x15e/0x1a9 [thinkpad_acpi] [ 6.090169] [<ffffffffc06e2fb5>] thinkpad_acpi_module_init.part.47+0x5e7/0x996 [thinkpad_acpi] [ 6.090174] [<ffffffffc06e3364>] ? thinkpad_acpi_module_init.part.47+0x996/0x996 [thinkpad_acpi] [ 6.090179] [<ffffffffc06e36af>] thinkpad_acpi_module_init+0x34b/0xc9c [thinkpad_acpi] [ 6.090181] [<ffffffffb4000450>] do_one_initcall+0x50/0x180 [ 6.090184] [<ffffffffb4177e12>] ? do_init_module+0x27/0x1ee [ 6.090186] [<ffffffffb41cc4b6>] ? kmem_cache_alloc_trace+0x156/0x1a0 [ 6.090188] [<ffffffffb4177e4a>] do_init_module+0x5f/0x1ee [ 6.090191] [<ffffffffb40ed562>] load_module+0x22c2/0x28d0 [ 6.090192] [<ffffffffb40ea0f0>] ? __symbol_put+0x60/0x60 [ 6.090195] [<ffffffffb42ee15d>] ? ima_post_read_file+0x7d/0xa0 [ 6.090198] [<ffffffffb42a809b>] ? security_kernel_post_read_file+0x6b/0x80 [ 6.090200] [<ffffffffb40eddcf>] SYSC_finit_module+0xdf/0x110 [ 6.090202] [<ffffffffb40ede1e>] SyS_finit_module+0xe/0x10 [ 6.090204] [<ffffffffb463d524>] entry_SYSCALL_64_fastpath+0x17/0x98 [ 6.090206] ---[ end trace ea6da61c1ec208d1 ]--- [ 6.090207] rfkill_any_led_trigger unlocked [ 6.091664] ------------[ cut here ]------------ ^ permalink raw reply [flat|nested] 5+ messages in thread
* "rfkill: Add rfkill-any LED trigger" causes deadlock 2016-12-16 16:46 ` "rfkill: Add rfkill-any LED trigger" causes deadlock Михаил Кринкин @ 2016-12-16 17:09 ` Mike Krinkin 2016-12-19 8:56 ` Johannes Berg 1 sibling, 0 replies; 5+ messages in thread From: Mike Krinkin @ 2016-12-16 17:09 UTC (permalink / raw) To: kernel, johannes.berg, linux-wireless, davem, netdev On Fri, Dec 16, 2016 at 07:46:06PM +0300, Михаил Кринкин wrote: > Hi, > > with recent i can't load my thinkpad with recent linux-next, bisect points > at the commit 73f4f76a196d7adb ("rfkill: Add rfkill-any LED trigger"). > > Problem occurs because thinkapd_acpi rfkill set_block handler > tpacpi_rfk_hook_set_block calls rfkill_set_sw_state, which in turn calls > new rfkill_any_led_trigger_event. So when rfkill_set_block called from > rfkill_register we have deadlock. > > I added WARN to __rfkill_any_led_trigger_event to see how deadlock occurs, > here is backtrace: > > [ 6.090079] WARNING: CPU: 2 PID: 307 at net/rfkill/core.c:184 > rfkill_any_led_trigger_event+0x2d/0x40 > [ 6.090080] reached __rfkill_any_led_trigger_event > [ 6.090081] Modules linked in: > [ 6.090082] snd_pcm sg thinkpad_acpi(+) mei_me nvram snd_seq mei > idma64 virt_dma intel_pch_thermal ucsi intel_lpss_pci snd_seq_device > hci_uart snd_timer snd btbcm soundcore btqca led_class btintel > bluetooth i8042 rtc_cmos serio evdev intel_lpss_acpi intel_lpss > acpi_pad tpm_infineon mfd_core kvm_intel kvm irqbypass ipv6 autofs4 > ext4 jbd2 mbcache sd_mod i915 i2c_algo_bit drm_kms_helper syscopyarea > sysfillrect sysimgblt fb_sys_fops drm ahci libahci video > pinctrl_sunrisepoint pinctrl_intel > [ 6.090112] CPU: 2 PID: 307 Comm: systemd-udevd Tainted: G W > 4.9.0-01741-g73f4f76-dirty #106 > [ 6.090113] Hardware name: LENOVO 20GJ004ERT/20GJ004ERT, BIOS > R0CET21W (1.09 ) 03/07/2016 > [ 6.090114] ffffb199c023f998 ffffffffb4334b6b ffffb199c023f9e8 > 0000000000000000 > [ 6.090117] ffffb199c023f9d8 ffffffffb40658ab 000000b84dd75d28 > 0000000080000006 > [ 6.090119] ffff99ea4dd75d28 0000000000000001 0000000000000001 > 0000000000000000 > [ 6.090122] Call Trace: > [ 6.090126] [<ffffffffb4334b6b>] dump_stack+0x4d/0x72 > [ 6.090128] [<ffffffffb40658ab>] __warn+0xcb/0xf0 > [ 6.090130] [<ffffffffb406592f>] warn_slowpath_fmt+0x5f/0x80 > [ 6.090132] [<ffffffffb4631bfd>] rfkill_any_led_trigger_event+0x2d/0x40 > [ 6.090135] [<ffffffffb46322d9>] rfkill_set_sw_state+0x89/0xd0 > [ 6.090142] [<ffffffffc06c9921>] > tpacpi_rfk_update_swstate+0x31/0x50 [thinkpad_acpi] > [ 6.090148] [<ffffffffc06c9972>] > tpacpi_rfk_hook_set_block+0x32/0x70 [thinkpad_acpi] > [ 6.090150] [<ffffffffb46327f0>] rfkill_set_block+0x90/0x160 > [ 6.090152] [<ffffffffb4632930>] __rfkill_switch_all+0x70/0xa0 > [ 6.090154] [<ffffffffb4633028>] rfkill_register+0x278/0x2b0 > [ 6.090159] [<ffffffffc06e1f0e>] tpacpi_new_rfkill+0xef/0x15d > [thinkpad_acpi] > [ 6.090164] [<ffffffffc06e2407>] bluetooth_init+0x15e/0x1a9 [thinkpad_acpi] > [ 6.090169] [<ffffffffc06e2fb5>] > thinkpad_acpi_module_init.part.47+0x5e7/0x996 [thinkpad_acpi] > [ 6.090174] [<ffffffffc06e3364>] ? > thinkpad_acpi_module_init.part.47+0x996/0x996 [thinkpad_acpi] > [ 6.090179] [<ffffffffc06e36af>] > thinkpad_acpi_module_init+0x34b/0xc9c [thinkpad_acpi] > [ 6.090181] [<ffffffffb4000450>] do_one_initcall+0x50/0x180 > [ 6.090184] [<ffffffffb4177e12>] ? do_init_module+0x27/0x1ee > [ 6.090186] [<ffffffffb41cc4b6>] ? kmem_cache_alloc_trace+0x156/0x1a0 > [ 6.090188] [<ffffffffb4177e4a>] do_init_module+0x5f/0x1ee > [ 6.090191] [<ffffffffb40ed562>] load_module+0x22c2/0x28d0 > [ 6.090192] [<ffffffffb40ea0f0>] ? __symbol_put+0x60/0x60 > [ 6.090195] [<ffffffffb42ee15d>] ? ima_post_read_file+0x7d/0xa0 > [ 6.090198] [<ffffffffb42a809b>] ? security_kernel_post_read_file+0x6b/0x80 > [ 6.090200] [<ffffffffb40eddcf>] SYSC_finit_module+0xdf/0x110 > [ 6.090202] [<ffffffffb40ede1e>] SyS_finit_module+0xe/0x10 > [ 6.090204] [<ffffffffb463d524>] entry_SYSCALL_64_fastpath+0x17/0x98 > [ 6.090206] ---[ end trace ea6da61c1ec208d1 ]--- > [ 6.090207] rfkill_any_led_trigger unlocked > [ 6.091664] ------------[ cut here ]------------ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "rfkill: Add rfkill-any LED trigger" causes deadlock 2016-12-16 16:46 ` "rfkill: Add rfkill-any LED trigger" causes deadlock Михаил Кринкин 2016-12-16 17:09 ` Mike Krinkin @ 2016-12-19 8:56 ` Johannes Berg 2016-12-19 14:01 ` Michał Kępień 1 sibling, 1 reply; 5+ messages in thread From: Johannes Berg @ 2016-12-19 8:56 UTC (permalink / raw) To: Михаил Кринкин, kernel, linux-wireless, davem, netdev Hi Mike, Thanks for the report. I'm sorry I missed this in review - obviously we can't call something that acquires the mutex from rfkill_set_sw_state() which clearly states, in the documentation: * This function can be called in any context, even from within rfkill * callbacks. I've reverted the change (and the follow-up fix) now. Michał, if you want to resubmit with this fixed, please also make sure you don't reintroduce the unused label warning and have the appropriate #ifdef that Arnd had later added for your change. Thanks, johannes ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "rfkill: Add rfkill-any LED trigger" causes deadlock 2016-12-19 8:56 ` Johannes Berg @ 2016-12-19 14:01 ` Michał Kępień 2016-12-20 7:47 ` Johannes Berg 0 siblings, 1 reply; 5+ messages in thread From: Michał Kępień @ 2016-12-19 14:01 UTC (permalink / raw) To: Johannes Berg Cc: Михаил Кринкин, linux-wireless, davem, netdev Mike, Johannes, sorry for the trouble caused. > Thanks for the report. I'm sorry I missed this in review - obviously we > can't call something that acquires the mutex from rfkill_set_sw_state() > which clearly states, in the documentation: > > * This function can be called in any context, even from within rfkill > * callbacks. Drat, I missed that, sorry. > I've reverted the change (and the follow-up fix) now. Just to ensure things get cleaned up properly, as of now it looks like you only reverted patch 2/2 of my v2 and Arnd's fix to patch 1/2, not patch 1/2 itself. > Michał, if you want to resubmit with this fixed, please also make sure > you don't reintroduce the unused label warning and have the appropriate > #ifdef that Arnd had later added for your change. Noted, thanks. I will post v3 once I figure out how to handle locking properly. -- Best regards, Michał Kępień ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "rfkill: Add rfkill-any LED trigger" causes deadlock 2016-12-19 14:01 ` Michał Kępień @ 2016-12-20 7:47 ` Johannes Berg 0 siblings, 0 replies; 5+ messages in thread From: Johannes Berg @ 2016-12-20 7:47 UTC (permalink / raw) To: Michał Kępień Cc: Михаил Кринкин, linux-wireless, davem, netdev > Just to ensure things get cleaned up properly, as of now it looks > like you only reverted patch 2/2 of my v2 and Arnd's fix to patch > 1/2, not patch 1/2 itself. Oops. I've fixed that up to only revert your patch - I wanted the revert in the tree to document the issue, rather than just dropping the patch entirely. Thanks for noticing that mistake. johannes ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-20 7:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161216163707.GA2629@gmail.com>
2016-12-16 16:46 ` "rfkill: Add rfkill-any LED trigger" causes deadlock Михаил Кринкин
2016-12-16 17:09 ` Mike Krinkin
2016-12-19 8:56 ` Johannes Berg
2016-12-19 14:01 ` Michał Kępień
2016-12-20 7:47 ` Johannes Berg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).