linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: IgorMitsyanko <igor.mitsyanko.os@quantenna.com>, jouni@qca.qualcomm.com
Cc: linux-wireless@vger.kernel.org, vamsin@qti.qualcomm.com
Subject: Re: [PATCH] cfg80211: Random local address for Public Action frame exchange
Date: Mon, 02 Jan 2017 12:28:43 +0100	[thread overview]
Message-ID: <1483356523.4596.12.camel@sipsolutions.net> (raw)
In-Reply-To: <cf228384-c98e-737e-3ba6-6c18e988210c@quantenna.com>

On Fri, 2016-12-30 at 22:55 +0300, IgorMitsyanko wrote:
> 
> > The driver needs to configure receive behavior to accept frames to
> > the
> > specified random address during the time the frame exchange is
> > pending
> > and such frames need to be acknowledged similarly to frames sent to
> > the
> > local permanent address when this random address functionality is
> > not
> > used.
> 
> A (probably) silly question: how wireless drivers are supposed to use
> SA 
> in a frame? I think drivers are not concerned about source address,
> they 
> simply pass whatever there is already set by userspace in 
> cfg80211_mgmt_tx_params::buf into air on Tx.
> And on Rx, they filter frames based on receiver address/BSSID, pass
> it 
> to upper layers and do not care what address is in DA (it is handled
> by 
> upper layers).

They do care about the DA in RX, since - as the commit message states -
"such frames need to be acknowledged [...]"

johannes

  reply	other threads:[~2017-01-02 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 20:39 [PATCH] cfg80211: Random local address for Public Action frame exchange Jouni Malinen
2016-12-30 19:55 ` IgorMitsyanko
2017-01-02 11:28   ` Johannes Berg [this message]
2017-01-02 14:29     ` IgorMitsyanko
2017-01-02 14:33       ` Johannes Berg
2017-01-02 11:34 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483356523.4596.12.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=igor.mitsyanko.os@quantenna.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vamsin@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).