From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from paleale.coelho.fi ([176.9.41.70]:34030 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965461AbdAILQa (ORCPT ); Mon, 9 Jan 2017 06:16:30 -0500 Message-ID: <1483960583.5227.24.camel@coelho.fi> (sfid-20170109_121749_910933_F4D8DEE5) From: Luca Coelho To: David Binderman , "johannes.berg@intel.com" , "emmanuel.grumbach@intel.com" , "linuxwifi@intel.com" , "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 09 Jan 2017 13:16:23 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious code ? Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2017-01-06 at 17:47 +0000, David Binderman wrote: > Hello there, Hi David, > 1. > > drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2039:14: warning: decrement of a boolean expression [-Wbool-operation] > > Source code is > > txq->block--; > > Maybe someone got a bool and a int mixed up ? > > 2. > > drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2045:14: warning: increment of a boolean expression [-Wbool-operation] > > Duplicate a few lines further down. Emmanuel has fixed this in our internal tree and I'll be sending it out together with our normal upstreaming process. Thanks for reporting! -- Cheers, Luca.