From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Subject: Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout
Date: Wed, 11 Jan 2017 14:31:31 +0100 [thread overview]
Message-ID: <1484141491.29931.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1483984388-30237-3-git-send-email-jouni@qca.qualcomm.com>
> + * @timeout_reason: reason for connection timeout. This is used when
> the
> + * connection fails due to a timeout instead of an explicit
> rejection from
> + * the AP. 0 (NL80211_CONNECT_TIMEOUT_UNSPECIFIED) is used
> for other cases.
I think this description is misleading - one could easily understand
"for other cases" to indicate for the cases that the AP did explicitly
reject it, but that's obviously not true.
Perhaps that could be reworded, to say it's used when it's not known,
or such? I'd not indicate the value (0) either, just specify the name,
and put a % in front to get better formatting for it please.
> + resp_ie_len, status, gfp,
> + NL80211_TIMEOUT_UNSPECIFIED);
> }
NL80211_CONNECT_TIMEOUT_UNSPECIFIED in the comment is wrong then.
johannes
next prev parent reply other threads:[~2017-01-11 13:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 17:53 [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs Jouni Malinen
2017-01-09 17:53 ` [PATCH v2 2/3] cfg80211: Add support to randomize TA of Public Action frames Jouni Malinen
2017-01-11 13:25 ` Johannes Berg
2017-01-09 17:53 ` [PATCH 3/3] cfg80211: Specify the reason for connect timeout Jouni Malinen
2017-01-09 20:24 ` Arend Van Spriel
2017-01-11 13:13 ` Malinen, Jouni
2017-01-11 13:26 ` Johannes Berg
2017-01-12 14:01 ` Malinen, Jouni
2017-01-11 13:31 ` Johannes Berg [this message]
2017-01-12 13:58 ` Malinen, Jouni
2017-01-12 14:06 ` Johannes Berg
2017-01-12 14:29 ` Malinen, Jouni
2017-01-12 14:32 ` Johannes Berg
2017-01-12 15:03 ` Malinen, Jouni
2017-01-09 20:07 ` [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs Arend Van Spriel
2017-01-11 7:48 ` Vamsi, Krishna
2017-01-11 13:22 ` Johannes Berg
2017-01-12 13:50 ` Vamsi, Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484141491.29931.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkushwah@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).