From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:33164 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbdAKOit (ORCPT ); Wed, 11 Jan 2017 09:38:49 -0500 Message-ID: <1484145522.29931.13.camel@sipsolutions.net> (sfid-20170111_153912_164760_562CE4FF) Subject: Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better From: Johannes Berg To: Arnd Bergmann Cc: linux-wireless@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 Jan 2017 15:38:42 +0100 In-Reply-To: <20170111143532.485827-1-arnd@arndb.de> References: <20170111143532.485827-1-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote: > gcc-7 complains that wl3501_cs passes NULL into a function that > then uses the argument as the input for memcpy: > > drivers/net/wireless/wl3501_cs.c: In function 'wl3501_get_scan': > include/net/iw_handler.h:559:3: error: argument 2 null where non-null > expected [-Werror=nonnull] >    memcpy(stream + point_len, extra, iwe->u.data.length); I love wext ;-) > This works fine here because iwe->u.data.length is guaranteed to be > NULL, and the memcpy doesn't actually have an effect. I think you mean 0, not NULL, but I can fix that when I apply it. johannes