From: Johannes Berg <johannes@sipsolutions.net>
To: Daniel Golle <daniel@makrotopia.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, lede-dev@lists.infradead.org,
openwrt-devel@lists.openwrt.org, john@phrozen.org, nbd@nbd.name,
roman@advem.lv, evaxige@qq.com, c.mignanti@gmail.com,
michel.stempin@wanadoo.fr, vasilugin@yandex.ru,
Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org
Date: Fri, 13 Jan 2017 16:59:59 +0100 [thread overview]
Message-ID: <1484323199.8670.5.camel@sipsolutions.net> (raw)
In-Reply-To: <20170113154629.GG2332@makrotopia.org> (sfid-20170113_164656_743337_630DDD13)
> The advantage of pull requests is that author information can be
> preserved more easily. Running git format-patch results in most
> patches
> having wrong SMTP sender information due to the assumption that the
> patch author is the same person also submitting the patch.
> So in practise, this would either require changing the From: (and
> thus
> Author) to myself or having most mails eaten by anti-spam measures
> due
> to non-matching SPF which prohibits my SMTP to send mail on behalf of
> the original authors of the patches.
>
This is completely untrue. If the first line of the *body* of the email
is "From: ..." then this is preserved as the author information by git
am, and doing so is also the default in git format-patch/send-email
when the author doesn't match the email configuration.
johannes
next prev parent reply other threads:[~2017-01-13 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 3:50 [RFC] [PULL REQUEST] rt2x00 patches from OpenWrt.org Daniel Golle
2017-01-13 10:46 ` Kalle Valo
2017-01-13 15:46 ` Daniel Golle
2017-01-13 15:59 ` Johannes Berg [this message]
2017-01-13 16:17 ` Daniel Golle
2017-01-13 22:17 ` [OpenWrt-Devel] " Daniel Golle
2017-01-13 21:22 ` Christian Lamparter
2017-01-13 14:15 ` Stanislaw Gruszka
2017-01-14 16:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484323199.8670.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=c.mignanti@gmail.com \
--cc=daniel@makrotopia.org \
--cc=evaxige@qq.com \
--cc=helmut.schaa@googlemail.com \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=lede-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michel.stempin@wanadoo.fr \
--cc=nbd@nbd.name \
--cc=openwrt-devel@lists.openwrt.org \
--cc=roman@advem.lv \
--cc=sgruszka@redhat.com \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).