From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Luca Coelho <luca@coelho.fi>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect
Date: Tue, 24 Jan 2017 09:57:31 +0100 [thread overview]
Message-ID: <1485248251.7244.3.camel@sipsolutions.net> (raw)
In-Reply-To: <bde55d09-6f3e-1f90-4aef-0e1169c11cf6@broadcom.com> (sfid-20170119_140531_409855_6CA9D983)
On Thu, 2017-01-19 at 14:08 +0100, Arend Van Spriel wrote:
>
> On 19-1-2017 13:00, Luca Coelho wrote:
> > On Thu, 2017-01-19 at 10:01 +0000, Arend van Spriel wrote:
> > > For wowlan netdetect a separate limit is defined for the number
> > > of
> > > matchsets. Currently, this limit is ignored and the regular limit
> > > for scheduled scan matchsets, ie. struct wiphy::max_match_sets,
> > > is
> > > used for the net-detect case as well.
> > >
> > > Cc: Luciano Coelho <luciano.coelho@intel.com>
> > > Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> > > ---
> >
> > What?! You don't have the same number of matchsets for both? :P
>
> Actually I have, but your comment mentioned they do not have to be
> the
> same. brcmfmac actually did not set max_nd_match_sets so I was
> surprised
> it worked. That said this patch will result in regression in brcmfmac
> :-p Not sure about other drivers supporting net-detect.
So do you want to submit a patch to brcmfmac first, and then I'll apply
this later? I can apply it and break it, but now that we already know
...?
johannes
next prev parent reply other threads:[~2017-01-24 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:01 [PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect Arend van Spriel
2017-01-19 12:00 ` Luca Coelho
2017-01-19 13:08 ` Arend Van Spriel
2017-01-24 8:57 ` Johannes Berg [this message]
2017-01-24 11:28 ` Arend Van Spriel
2017-01-27 11:25 ` Arend Van Spriel
2017-01-27 11:27 ` Johannes Berg
2017-01-27 11:29 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485248251.7244.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).