From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/5] nl80211: fix validation of scheduled scan info for wowlan netdetect
Date: Fri, 27 Jan 2017 13:31:28 +0100 [thread overview]
Message-ID: <1485520288.5851.8.camel@sipsolutions.net> (raw)
In-Reply-To: <1485518971-28183-2-git-send-email-arend.vanspriel@broadcom.com> (sfid-20170127_132234_218655_59FDFD26)
On Fri, 2017-01-27 at 12:09 +0000, Arend van Spriel wrote:
> For wowlan netdetect a separate limit is defined for the number of
> matchsets. Currently, this limit is ignored and the regular limit
> for scheduled scan matchsets, ie. struct wiphy::max_match_sets, is
> used for the net-detect case as well.
>
But .. this patch shouldn't be first in the series, should it? That
leaves brcmfmac broken inbetween.
Also, since you fix the brcmfmac value in patch 2, and it's the same in
both cases, I don't really see a dependency of anything *on* the
nl80211 patch? The brcmfmac changes can go in without it entirely, and
have no effect whatsoever, no?
IOW, I think Kalle can merge 2-5, and I can then pick up this one when
they hit net-next and I've synchronized, no?
johannes
next prev parent reply other threads:[~2017-01-27 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 12:09 [PATCH 0/5] nl802111/brcmfmac: wowlan netdetect fixes Arend van Spriel
2017-01-27 12:09 ` [PATCH 1/5] nl80211: fix validation of scheduled scan info for wowlan netdetect Arend van Spriel
2017-01-27 12:31 ` Johannes Berg [this message]
2017-01-27 12:38 ` Arend Van Spriel
2017-01-27 12:42 ` Johannes Berg
2017-02-08 9:10 ` Johannes Berg
2017-02-08 9:56 ` Arend Van Spriel
2017-01-27 12:09 ` [PATCH 2/5] brcmfmac: provide a value for struct wowlan_support::max_nd_match_sets Arend van Spriel
2017-01-27 12:09 ` [PATCH 3/5] brcmfmac: fix handling firmware results for wowl netdetect Arend van Spriel
2017-01-27 12:09 ` [PATCH 4/5] brcmfmac: allow wowlan support to be per device Arend van Spriel
2017-01-27 12:22 ` Arend Van Spriel
2017-01-27 12:09 ` [PATCH 5/5] brcmfmac: add .update_connect_params() callback Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485520288.5851.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).