From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
Ashok Raj Nagarajan <arnagara@codeaurora.org>
Cc: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated
Date: Mon, 06 Feb 2017 15:38:13 +0100 [thread overview]
Message-ID: <1486391893.5430.6.camel@sipsolutions.net> (raw)
In-Reply-To: <00887d68-80b7-cf80-e426-e3772d8122f1@candelatech.com>
> You use value '0' to mean set to default values, as far as I can
> tell.
I think you're confusing the internal API and the userspace API - at a
userspace level you have to set NL80211_ATTR_STA_TX_POWER_SETTING to
NL80211_TX_POWER_AUTOMATIC to revert back to defaults, no?
For perfect backwards compatibility we should ignore it if not
supported, but that doesn't really make sense - I think we should
reject it and handle errors elsewhere in the not supported case.
johannes
prev parent reply other threads:[~2017-02-06 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:41 [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated Ashok Raj Nagarajan
2017-01-31 18:41 ` [PATCH v2 2/2] mac80211: store tx power value from user to station Ashok Raj Nagarajan
2017-01-31 19:00 ` Ben Greear
2017-02-01 17:29 ` Ashok Raj Nagarajan
2017-02-01 17:32 ` Ben Greear
2017-02-01 17:47 ` Ashok Raj Nagarajan
2017-01-31 19:06 ` [PATCH v2 1/2] cfg80211: Add support to set tx power for a station associated Ben Greear
2017-02-01 17:27 ` Ashok Raj Nagarajan
2017-02-01 17:36 ` Ben Greear
2017-02-01 17:57 ` Ashok Raj Nagarajan
2017-02-01 18:08 ` Ben Greear
2017-02-06 14:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486391893.5430.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnagara@codeaurora.org \
--cc=arnagara@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).